You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/26 17:14:50 UTC
[GitHub] [incubator-doris] JNSimba opened a new pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
JNSimba opened a new pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232
## Proposed changes
The previous DataSourceFunction inherited from RichSourceFunction. As a result, no matter how much the parallelism of flink is set, the parallelism of DataSourceFunction is only 1.
Now modify it to **RichParallelSourceFunction**.
And when flink has multiple degrees of parallelism, assign the doris data to each parallelism.
For example, read dorisPartitions.size = 10, flink.parallelism = 4
The task is split as follows:
task0: dorisPartitions[0],[1],[2]
task1: dorisPartitions[3],[4],[5]
task2: dorisPartitions[6],[7]
task3: dorisPartitions[8],[9]
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
Posted by GitBox <gi...@apache.org>.
hf200012 commented on pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232#issuecomment-994477987
> > LGTM
>
> Hi @hf200012 , I have talked to @JNSimba in private that this PR need further modification. Because currently implementation will lead to duplicate data processing and some other problem.
OK，@JNSimba and I are communicating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] JNSimba commented on pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
Posted by GitBox <gi...@apache.org>.
JNSimba commented on pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232#issuecomment-989428256
Optimized task allocation algorithm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232#issuecomment-986047113
> LGTM
Hi @hf200012 , I have talked to @JNSimba in private that this PR need further modification.
Because currently implementation will lead to duplicate data processing and some other problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7232: [improvement](flink-connector) DataSourceFunction read doris supports parallel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7232:
URL: https://github.com/apache/incubator-doris/pull/7232#issuecomment-986046699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org