You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "markobean (via GitHub)" <gi...@apache.org> on 2023/07/30 02:03:54 UTC
[GitHub] [nifi] markobean opened a new pull request, #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
markobean opened a new pull request, #7541:
URL: https://github.com/apache/nifi/pull/7541
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
Added a feature for adding Comments to individual Rules in the Advanced UI of the UpdateAttribute processor. This provides a better location to provide comments as they apply to a particular rule. The only alternative is to document Rules in the Comments tab of the processor. This is too far removed from the Rule to be easy to associate the comment with the Rule - and is highly susceptible to the comment becoming stale relative to rule changes.
[NIFI-11877](https://issues.apache.org/jira/browse/NIFI-11877)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
This PR is largely a UI feature. Add Rules in the Advanced UI of UpdateAttribute. Comments are able to be added and persist. Also, when creating a new Rule based on an existing Rule, the Comments field carries forward.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
Posted by "markobean (via GitHub)" <gi...@apache.org>.
markobean commented on PR #7541:
URL: https://github.com/apache/nifi/pull/7541#issuecomment-1682400255
@exceptionfactory Any additional comments on this one? Or can we stick a fork in it and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
URL: https://github.com/apache/nifi/pull/7541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7541:
URL: https://github.com/apache/nifi/pull/7541#issuecomment-1682659693
> @exceptionfactory Any additional comments on this one? Or can we stick a fork in it and merge?
Thanks for the follow up @markobean, I will review the latest updates soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #7541: NIFI-11877 add a Comments field for Rules in UpdateAttribute processor
Posted by "markobean (via GitHub)" <gi...@apache.org>.
markobean commented on PR #7541:
URL: https://github.com/apache/nifi/pull/7541#issuecomment-1668298888
> @markobean Can you rebase this pull request on the latest main branch? Recent changes addressed issues with failing QuestDB tests, so it would be helpful to incorporate those changes and confirm clean automated builds.
Rebased, ran build with `-Pcontrib-check`, pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org