You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 14:45:07 UTC
[GitHub] [arrow-datafusion] retikulum opened a new pull request, #4244: Improve Error Handling and Readibility for downcasting `Float32Array`, `Float32Array`, `StringArray`
retikulum opened a new pull request, #4244:
URL: https://github.com/apache/arrow-datafusion/pull/4244
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #3152.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
It is very clear in the issue but there are different schemas while downcasting an ArrayRef to a related arrow array type. This is the new PR of improving downcasting to `Decimal128Array`
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- `as_decimal128_array` is created in `datafusion\common\src\cast.rs`
- Refactor parts where following lines are used:
```rust
as_any().downcast_ref::<Decimal128Array>().unwrap()
```
```rust
as_decimal_array()
```
- This commit passed related tests.
- Change `get_decimal_value_from_array` functions return type `ScalarValue` to `Result<ScalarValue>`
- Out of scope but `dyn_cmp_dict` is added to `datafusion\physical-expr\Cargo.toml` for passing `test_dictionary_type_to_array_coersion`. Before adding to this, following error was returned.
```rust
Error: ArrowError(CastError("Comparing array of type Dictionary(Int32, Utf8) with array of type Dictionary(Int32, Utf8) requires \"dyn_cmp_dict\" feature"))
```
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
I am not sure about it.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 merged pull request #4244: Improve Error Handling and Readibility for downcasting `Float32Array`, `Float64Array`, `StringArray`
Posted by GitBox <gi...@apache.org>.
liukun4515 merged PR #4244:
URL: https://github.com/apache/arrow-datafusion/pull/4244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4244: Improve Error Handling and Readibility for downcasting `Float32Array`, `Float64Array`, `StringArray`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4244:
URL: https://github.com/apache/arrow-datafusion/pull/4244#issuecomment-1317949581
Benchmark runs are scheduled for baseline = 5de9709fadf1344baca1ed3e1f9a44e06dfa9a63 and contender = f4996b9f475b04bd260221f2a2bb074ab09b96be. f4996b9f475b04bd260221f2a2bb074ab09b96be is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9a0133e6383741d98a0cb4e19945f77f...e0ed9f0057df431fa696e4a96ce8ffe1/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ad2b34eb160b4a5dad8215adc0ec7792...f3d452829bb245ca8c44199c9da3c1c5/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e403d31c1ae14a9cb9d7cd40ad3a3161...14751f7f21f74cdb83d2ffa3017f58eb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dedd3850b59349158d1d1247c9b0cfb1...9740f526e5d34368b7ed0909f9b8b38d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org