[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089132#comment-16089132 ] 

ASF GitHub Bot commented on CB-12766:
-------------------------------------

Github user G-Rath commented on the issue:

    https://github.com/apache/cordova-lib/pull/558
  
    @stevengill I really agree with @uloco - Not only for the reason of consistent, but because the constant removal of the last line is picked up by VCSs, which can be really annoying. 
    
    While you've attached uloco's comment to CB-12810, I've noticed that it's been marked as fixed. 
    
    Because of the way the new line removal effects VCSs, I'd consider this a bug (even if a minor one).
    
    While I'm happy to (and normally would just) file a bug report, since you've already commented on it, and there is technically an issue already for it, can I leave it in your hands to make sure this gets considered?
    
    Thanks :)


> Cordova CLI changes package.json indentation
> --------------------------------------------
>
>                 Key: CB-12766
>                 URL: https://issues.apache.org/jira/browse/CB-12766
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-lib
>    Affects Versions: 7.0.0
>            Reporter: Remco Haszing
>            Assignee: Kerri Shotts
>            Priority: Minor
>              Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json several times. In this process the indentation of package.json alternates between 2 and 4 spaces. The final result is an indentation of 4 spaces, which conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org