[GitHub] [couchdb-helm] rileyai-dev commented on a diff in pull request #106: Simplify admin hash in the secret

[GitBox <gi...@apache.org>]

rileyai-dev commented on code in PR #106:
URL: https://github.com/apache/couchdb-helm/pull/106#discussion_r1064570615


##########
couchdb/README.md:
##########
@@ -86,6 +79,7 @@ and then install the chart while overriding the `createAdminSecret` setting:
 $ helm install \
   --name my-release \
   --version=3.6.1 \
+  --set adminHash=true/false \

Review Comment:
   Well... you are right but if you set your own secret with your own adminHash, the script admin-hash-copy in statefulset.yaml won't run (this behavior is inherited from the previous chart, I discovered this limitation and thought it would be good to put it somewhere in the doc!). So yes, you could put the adminHash to the real value but the whole purpose of using your own secret is to hide sensitive data from helm.
   
   It's definitely not a best practice but I simply kept the default behavior from the previous chart...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org