You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/11 08:45:28 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

weizhouapache opened a new pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069


   ## Description
   <!--- Describe your changes in detail -->
   
   This aims to support Ubuntu 20.04 as a hypervisor in cloudstack 4.15
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [X] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629733078


   @weizhouapache (cc @shwstppr @davidjumani - perhaps check on CentOS8 the version of openssh-server/sshd) I found that openssh-server v7+ per their release notes has deprecated some options that our SSH utility/class uses (needs investigation) which is why CloudStack fails to ssh into KVM host for newer distros, to fix it I had to add the following to the sshd config:
   ```
   PubkeyAcceptedKeyTypes=+ssh-dss
   HostKeyAlgorithms=+ssh-dss 
   KexAlgorithms=+diffie-hellman-group1-sha1
   ```
   
   For reference, my test env:
   ```
   # lsb_release -d && ssh -V
   Description:	Ubuntu 20.04 LTS
   OpenSSH_8.2p1 Ubuntu-4, OpenSSL 1.1.1f  31 Mar 2020
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630116024


   > @rhtyd The snapshot issue also exists under 18.04. Qemu now locks a QCOW2 file and thus can't be snapshotted while the VM is running in order to protect the QCOW2 file.
   
   @wido @rhtyd I was able to snapshot a stopped VM. Probably some caching issue in my UI else it should have stopped the operation. Checking that. This should be a non-issue otherwise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] wido commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629753802


   @weizhouapache I am +1 for dropping 16.04 support in 4.15. As this will be an LTS which will be maintained beyond April 2021 and Ubuntu 16.04 is then no longer supported.
   
   18.04 and 20.04 should be the supported Ubuntu distro's then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] wido commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630100013


   @rhtyd The snapshot issue also exists under 18.04. Qemu now locks a QCOW2 file and thus can't be snapshotted while the VM is running in order to protect the QCOW2 file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629764168


   > When using addHost API, it fails to add host with:
   > 
   > ```
   > 2020-05-17 02:11:42,913 INFO  [c.c.r.ResourceManagerImpl] (qtp1916575798-22:ctx-998dc1cb ctx-3489fe88) (logid:59229745) Trying to add a new host at http://192.168.1.11 in data center 1
   > 2020-05-17 02:11:42,951 WARN  [c.c.h.k.d.LibvirtServerDiscoverer] (qtp1916575798-22:ctx-998dc1cb ctx-3489fe88) (logid:59229745)  can't setup agent, due to java.io.IOException: There was a problem while connecting to 192.168.1.11:22 - There was a problem while connecting to 192.168.1.11:22
   > ```
   > 
   > @weizhouapache have you seen such an error (I tried to use both the zone deployment wizard and addHost API where this fails)? Could this be due to default ssh algorithms issue or our ssh utility class needing any change? Thanks.
   
   @rhtyd is the issue fixed with the new ssh config ?
   I was able to add Ubuntu 20.04 host in my testing env.
   
   Two issues need to mention: 
   (1) there are some issues with ./python/lib/cloudutils/serviceConfig.py, please configure cloudbr0 or cloudbrX before adding the host.
   (2) I had problem when I created and configured a Ubuntu 20.04 vm on CentOS 7 host. so I created a Ubuntu 20.04 vm on a Ubuntu 16.04 host which works fine.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630097966


   Hi @weizhouapache - yes the addHost ssh issue is fixed with the changes to sshd_config
   - Thanks I've verified the -F option with qemu-img on Ubuntu 16.04 - you're right. That means we don't need to explicitly deprecate 16.04 wrt these changes. But I'm okay to drop 16.04 support in future releases (4.16 maybe)
   - Yes, in my testing I had added cloudbr0 before adding the host
   
   On further testing my colleagues (@shwstppr) found an issue with newer qemu when trying to take a volume snapshot:
   ```
   com.cloud.utils.exception.CloudRuntimeException: qemu-img: Could not open '/mnt/05c30f6d-5725-3369-a8d6-b5fb37c7ba8f/20dc7b29-934a-409a-babf-f4527f574377': Failed to get shared "write" lockIs another process using the image [/mnt/05c30f6d-5725-3369-a8d6-b5fb37c7ba8f/20dc7b29-934a-409a-babf-f4527f574377]?there is no 62f4eb05-168e-4161-a070-f8804df068d0 on disk /mnt/05c30f6d-5725-3369-a8d6-b5fb37c7ba8f/20dc7b29-934a-409a-babf-f4527f574377
   	at org.apache.cloudstack.storage.snapshot.SnapshotServiceImpl.backupSnapshot(SnapshotServiceImpl.java:301)
   	at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.backupSnapshot(DefaultSnapshotStrategy.java:171)
   	at com.cloud.storage.snapshot.SnapshotManagerImpl.backupSnapshotToSecondary(SnapshotManagerImpl.java:1213)
   	at com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:1164)
   ```
   Have to seen this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd edited a comment on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629736332


   @weizhouapache cc @shwstppr @davidjumani @wido @GabrielBrascher @PaulAngus @andrijapanicsb @DaanHoogland @kiwiflyer and others
   I found Ubuntu 16.04 has an older qemu-img that does not support that `-F` option with `qemu-img create` command:
   ```
   qemu-img version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.43), Copyright (c) 2004-2008 Fabrice Bellard
   usage: qemu-img command [command options]
   QEMU disk image utility
   
   Command syntax:
     check [-q] [-f fmt] [--output=ofmt] [-r [leaks | all]] [-T src_cache] filename
     create [-q] [-f fmt] [-o options] filename [size]
   ```
   I checked CentOS7 and that was okay (qemu-img create supports `-F` <backing file format>).
   
   Let's discuss:
   - Either to add code to work around this issue, or
   - Deprecate Ubuntu 16.04 as an unsupported/older KVM host platform in 4.15 (I agree on this, given the distribution is old, however, it will EOL in April 2021)
   - In release/upgrade notes, ask admin to install a more recent qemu-img (and any other qemy or libvirt related dependency from bionic/18.04 repos).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#discussion_r422977886



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -144,6 +148,14 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
             // delete the metadata of vm snapshots before migration
             vmsnapshots = libvirtComputingResource.cleanVMSnapshotMetadata(dm);
 
+            // Verify Format of backing file
+            for (DiskDef disk : disks) {
+                if (disk.getDeviceType() == DiskDef.DeviceType.DISK

Review comment:
       Could this break on older CentOS/Ubuntu KVM hosts where the backfile is not supported?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636816318


   Packaging result: ✔centos7 ✔debian. JID-1260


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-724683100


   > LGTM, here is what I've tested:
   > 
   > KVM operations:
   > 
   > * VM lifecycle - deploy, console view, stop/start on different host, reinstall, reboot, save/restore VM snapshot, migrate, attach/detach ISO, deploy VM from ISO/template, reset SSH pair, scale VM, delete
   > * Add/remove host
   
   @vladimirpetrov thanks for testing.
   However, this pr has been closed, as 3 of 4 commits have been merged into mainstream already.
   What have you tested ? mainsteam, or 4.14 + this pr ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636803211


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-626650193


   Related PR for same effort, different distro - likely some overlaping bits - https://github.com/apache/cloudstack/pull/4068


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629734184


   @weizhouapache another issue, on deployment of systemvms with MySQL 8.0 cc @shwstppr @davidjumani deployment fails with:
   ```
   Caused by: java.sql.SQLIntegrityConstraintViolationException: Column 'update_time' cannot be null
   ```
   I applied a quick fix to modify the default time to be null:
   ```
   ALTER TABLE nics MODIFY COLUMN update_time timestamp NULL;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#discussion_r422978904



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
##########
@@ -149,6 +149,8 @@ public void create(final QemuImgFile file, final QemuImgFile backingFile, final
          */
         s.add("-f");
         if (backingFile != null) {
+            s.add(backingFile.getFormat().toString());
+            s.add("-F");

Review comment:
       @weizhouapache I checked libvirtd release notes, libvirt doesn't fail VM for version 5.x or below; only libvirt starting version 6.x fails VM deployment if backing file format is not provided. Should we add a check, as the `-F` option is not available for qemu-img on older distros, say CentOS7, or Ubuntu 16.04 (I didn't check 18.04). Unless we want to discuss and deprecate Ubuntu 16.04 support? cc @wido @GabrielBrascher @shwstppr @davidjumani 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636803646


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629736332


   @weizhouapache cc @shwstppr @davidjumani @wido @GabrielBrascher @PaulAngus @andrijapanicsb @DaanHoogland @kiwiflyer and others
   I found Ubuntu 16.04 has an older qemu-img that does not support that `-F` option with `qemu-img create` command:
   ```
   qemu-img version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.43), Copyright (c) 2004-2008 Fabrice Bellard
   usage: qemu-img command [command options]
   QEMU disk image utility
   
   Command syntax:
     check [-q] [-f fmt] [--output=ofmt] [-r [leaks | all]] [-T src_cache] filename
     create [-q] [-f fmt] [-o options] filename [size]
   ```
   I checked CentOS7 and that was okay (qemu-img create supports `-F` <backing file format>).
   
   Let's discuss:
   - Either to add code to work around this issue, or
   - Deprecate Ubuntu 16.04 as an unsupported/older KVM host platform in 4.15 (I agree on this, given the distribution is old, however, it will EOL in April 2021)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-645108680


   @weizhouapache can you check and close, we used your commits as reference and included here for consolidated fixes and testing - https://github.com/apache/cloudstack/pull/4068


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-653724377


   Closing due to cherry-picked in https://github.com/apache/cloudstack/pull/4068


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629763333


   @rhtyd 
   I checked ubuntu 16.04 just now. you are right. "qemu-img -F" is not supported as mentioned in help. However  the backing file format is set when I create qcow2 with "-F",  hence I think help is not updated. see below.
   
   ```
   root@node42:~# qemu-img create -b /mnt/ee9ffb52-bd20-3328-8a7f-090723db12c4/bd84bcd9-d040-4e9f-a777-617c712b10dc -f qcow2 -F qcow2 bb
   Formatting 'bb', fmt=qcow2 size=2097152000 backing_file=/mnt/ee9ffb52-bd20-3328-8a7f-090723db12c4/bd84bcd9-d040-4e9f-a777-617c712b10dc backing_fmt=qcow2 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16
   
   root@node42:~# qemu-img info bb
   image: bb
   file format: qcow2
   virtual size: 2.0G (2097152000 bytes)
   disk size: 196K
   cluster_size: 65536
   backing file: /mnt/ee9ffb52-bd20-3328-8a7f-090723db12c4/bd84bcd9-d040-4e9f-a777-617c712b10dc
   backing file format: qcow2
   Format specific information:
       compat: 1.1
       lazy refcounts: false
       refcount bits: 16
       corrupt: false
   ```
   
   anyway, I agee with @wido we can probably drop Ubuntu 16.04 support if we release 4.15 next year


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-629732218


   When using addHost API, it fails to add host with:
   ```
   2020-05-17 02:11:42,913 INFO  [c.c.r.ResourceManagerImpl] (qtp1916575798-22:ctx-998dc1cb ctx-3489fe88) (logid:59229745) Trying to add a new host at http://192.168.1.11 in data center 1
   2020-05-17 02:11:42,951 WARN  [c.c.h.k.d.LibvirtServerDiscoverer] (qtp1916575798-22:ctx-998dc1cb ctx-3489fe88) (logid:59229745)  can't setup agent, due to java.io.IOException: There was a problem while connecting to 192.168.1.11:22 - There was a problem while connecting to 192.168.1.11:22
   ```
   @weizhouapache have you seen such an error (I tried to use both the zone deployment wizard and addHost API where this fails)? Could this be due to default ssh algorithms issue or our ssh utility class needing any change? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630110604


   @shwstppr ping - can you check and confirm Wido's comment?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4069: [WIP] Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#discussion_r422977620



##########
File path: debian/cloudstack-agent.postinst
##########
@@ -46,6 +46,11 @@ case "$1" in
             fi
         fi
 
+        # Create symbolic link for python
+        if [ ! -f "/usr/bin/python" ]; then
+            ln -s /usr/bin/python2 /usr/bin/python

Review comment:
       Hi @weizhouapache - my colleagues @shwstppr @davidjumani are working to support python2 to python3 in #4068, so all scripts that run on management server and kvm host towards 4.15/milestone. So this change is not needed, and may break things (we probably don't want misleading symlinks that could mean python2 or python3). cc @wido @GabrielBrascher 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-724687952


   Hi @weizhouapache, this was tested on the latest mainstream, the idea was to double-check the feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-637311114


   <b>Trillian test result (tid-1597)</b>
   Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 59276 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4069-t1597-kvm-ubuntu18.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 78 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 35.90 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 387.26 | test_deploy_vm_extra_config_data.py
   test_01_deploy_kubernetes_cluster | `Error` | 3615.35 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Failure` | 2301.75 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 3610.04 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 34.72 | test_kubernetes_clusters.py
   test_01_snapshot_root_disk | `Error` | 8.25 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 6.21 | test_usage.py
   test_06_download_detached_volume | `Error` | 9.31 | test_volumes.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-724599414


   LGTM, here is what I've tested:
   
   KVM operations:
   * VM lifecycle - deploy, console view, stop/start on different host, reinstall, reboot, save/restore VM snapshot, migrate, attach/detach ISO, deploy VM from ISO/template, reset SSH pair, scale VM, delete
   * Add/remove host


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org