You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/10/11 07:40:00 UTC
[jira] [Commented] (HIVE-17736) ObjectStore transaction handling
can be simplified
[ https://issues.apache.org/jira/browse/HIVE-17736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646065#comment-16646065 ]
Hive QA commented on HIVE-17736:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892187/HIVE-17736.01.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14366/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14366/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14366/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-10-11 07:38:28.557
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-14366/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-10-11 07:38:28.561
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 37c7fd7 HIVE-20705: Vectorization: Native Vector MapJoin doesn't support Complex Big Table values (Matt McCline, reviewed by Jason Dere)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 37c7fd7 HIVE-20705: Vectorization: Native Vector MapJoin doesn't support Complex Big Table values (Matt McCline, reviewed by Jason Dere)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-10-11 07:38:29.636
+ rm -rf ../yetus_PreCommit-HIVE-Build-14366
+ mkdir ../yetus_PreCommit-HIVE-Build-14366
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-14366
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-14366/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: a/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index
error: a/metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java: does not exist in index
error: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index
error: metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java: does not exist in index
error: src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index
error: src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java: does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-14366
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12892187 - PreCommit-HIVE-Build
> ObjectStore transaction handling can be simplified
> --------------------------------------------------
>
> Key: HIVE-17736
> URL: https://issues.apache.org/jira/browse/HIVE-17736
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Alexander Kolbasov
> Priority: Major
> Attachments: HIVE-17736.01.patch
>
>
> There are many places in ObjectStore that do something like this:
> {code}
> boolean commited = false;
> try {
> openTransaction();
> commited = commitTransaction();
> } finally {
> if (!commited) {
> rollbackTransaction();
> }
> }
> {code}
> We can simplify this in two ways:
> 1) Create a wrapper that calls given piece of code inside the block of code above. This is similar to TransactionManager in Sentry.
> 2) Create a special auto-closeable object that does the check and rollback on close.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)