You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/01/29 16:44:36 UTC
[GitHub] brooklyn-server pull request #943: Only log.warn once on feed failure
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/943
Only log.warn once on feed failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix-logWarn-once-on-feed-failure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #943
----
commit f6a2ed158400761a30b4c9f82e353f11b33e1934
Author: Aled Sage <al...@...>
Date: 2018-01-29T16:41:23Z
EntityInitializers.resolve config: return default val
commit 3b64d8bb1eda5e438026481efae850c747ceb9b1
Author: Aled Sage <al...@...>
Date: 2018-01-29T16:43:27Z
Sensor feeds: avoid repeated log.warn on failure
----
---
[GitHub] brooklyn-server pull request #943: Only log.warn once on feed failure
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/943
---
[GitHub] brooklyn-server issue #943: Only log.warn once on feed failure
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/943
Thanks @geomacy @drigodwin - I'd accidentally deleted the `LogWatcher.getEvents(Predicate)` method, so I've reverted that (and squashed into a single commit)!
---
[GitHub] brooklyn-server issue #943: Only log.warn once on feed failure
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/943
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests/test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSensorTest.java:[390,39] method getEvents in class org.apache.brooklyn.test.LogWatcher cannot be applied to given types;
required: no arguments
found: com.google.common.base.Predicate<ch.qos.logback.classic.spi.ILoggingEvent>
reason: actual and formal argument lists differ in length
```
---