You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/20 09:28:35 UTC

[GitHub] [kafka] wenbingshen commented on a change in pull request #10346: KAFKA-12493: The controller should handle the consistency between the controllerContext and the partition replicas assignment on zookeeper

wenbingshen commented on a change in pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#discussion_r598088143



##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -1680,45 +1680,61 @@ class KafkaController(val config: KafkaConfig,
   private def processPartitionModifications(topic: String): Unit = {
     def restorePartitionReplicaAssignment(
       topic: String,
-      newPartitionReplicaAssignment: Map[TopicPartition, ReplicaAssignment]
+      restorePartitionReplicaAssignment: Map[TopicPartition, ReplicaAssignment]

Review comment:
       Thanks for your comment.As you said, it is indeed complicated, I have written a comment for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org