You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/03 21:38:31 UTC
Review Request 55152: Fixed nested container docs and added a link to
home.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55152/
-----------------------------------------------------------
Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone.
Repository: mesos
Description
-------
Fixed nested container docs and added a link to home.md.
Diffs
-----
docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4
docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
Diff: https://reviews.apache.org/r/55152/diff/
Testing
-------
https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
Thanks,
Gilbert Song
Re: Review Request 55152: Fixed nested container docs and added a
link to home.md.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55152/#review160437
-----------------------------------------------------------
docs/nested-container-and-task-group.md (line 64)
<https://reviews.apache.org/r/55152/#comment231588>
s/of Nested Container/of a Nested Container
docs/nested-container-and-task-group.md (lines 67 - 69)
<https://reviews.apache.org/r/55152/#comment231589>
We could re-write this as follows:
In order for executors to launch nested containers, a new set of agent APIs have been introduced (described in the following sections), which would allow the exector to re-use the isolation semantics provided by the `MesosContainerizer` without needing to reimplement this code within the executor. While currently executors are assumed to be the primary consumers of the new agent APIs, its important to note that the API has been designed to allow any authorized operator to launch nested containers.
docs/nested-container-and-task-group.md (line 209)
<https://reviews.apache.org/r/55152/#comment231579>
s/2/two
better to write the numeral in words when it modifies the noun.
Lets not mention version numbers in the docs. We can re-write this as:
Currently, this API supports only two levels of nesting.
(You can start the above in a new paragraph for emphasis)
docs/nested-container-and-task-group.md (line 211)
<https://reviews.apache.org/r/55152/#comment231580>
Theoretically, we could have up to 32 nested levels, limited by the maximum dept of [pid namespace]
- Avinash sridharan
On Jan. 3, 2017, 9:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55152/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 9:44 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed nested container docs and added a link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4
> docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
>
> Diff: https://reviews.apache.org/r/55152/diff/
>
>
> Testing
> -------
>
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 55152: Fixed nested container docs and added a
link to home.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55152/#review160552
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54013, 54073, 54074, 55152]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 3, 2017, 9:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55152/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 9:44 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed nested container docs and added a link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4
> docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
>
> Diff: https://reviews.apache.org/r/55152/diff/
>
>
> Testing
> -------
>
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 55152: Fixed nested container docs and added a
link to home.md.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55152/#review160456
-----------------------------------------------------------
minor comments
docs/nested-container-and-task-group.md (line 2)
<https://reviews.apache.org/r/55152/#comment231601>
Maybe put "pods" in the page title, for SEO?
docs/nested-container-and-task-group.md (line 125)
<https://reviews.apache.org/r/55152/#comment231604>
Have you verified this anchor link using `site/Dockerfile` to generate the website, rather than just following github markdown?
- Adam B
On Jan. 3, 2017, 1:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55152/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 1:44 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed nested container docs and added a link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4
> docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
>
> Diff: https://reviews.apache.org/r/55152/diff/
>
>
> Testing
> -------
>
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 55152: Fixed nested container docs and added a
link to home.md.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55152/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 1:44 p.m.)
Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone.
Changes
-------
Simplified the doc title in home.md
Repository: mesos
Description
-------
Fixed nested container docs and added a link to home.md.
Diffs (updated)
-----
docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4
docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
Diff: https://reviews.apache.org/r/55152/diff/
Testing
-------
https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
Thanks,
Gilbert Song