[jira] [Commented] (FLINK-7535) Port DashboardConfigHandler to new REST endpoint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172907#comment-16172907 ] 

ASF GitHub Bot commented on FLINK-7535:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4604#discussion_r139907889
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java ---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler;
    +
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.WebOptions;
    +import org.apache.flink.util.Preconditions;
    +
    +import java.io.File;
    +
    +/**
    + * Configuration object containing values for the rest handler configuration.
    + */
    +public class RestHandlerConfiguration {
    +
    +	private final long refreshInterval;
    +
    +	private final Time timeout;
    +
    +	private final File tmpDir;
    +
    +	public RestHandlerConfiguration(long refreshInterval, Time timeout, File tmpDir) {
    +		this.refreshInterval = refreshInterval;
    --- End diff --
    
    Is it required that we have a validation check for this? Although I don't think we ever had a validation check for this before.


> Port DashboardConfigHandler to new REST endpoint
> ------------------------------------------------
>
>                 Key: FLINK-7535
>                 URL: https://issues.apache.org/jira/browse/FLINK-7535
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> In order to use the {{DashboardConfigHandler}} for the new {{RestServerEndpoint}} we have to let it implement the {{LegacyRestHandler}} interface. Moreover, we have to define the appropriate {{MessageHeaders}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)