You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2016/08/12 06:14:37 UTC
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1636
Fix a quote issue with Spanish L10N (from transifex translation)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack L10N-update-4.8-20160812-fix-spanish-quote
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1636
----
commit 47f458698de2f998d4f8e57cad31dcbf900d78f5
Author: Milamber <mi...@apache.org>
Date: 2016-08-12T06:13:44Z
Fix a quote issue with Spanish L10N (from transifex translation)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
Posted by milamberspace <gi...@git.apache.org>.
GitHub user milamberspace reopened a pull request:
https://github.com/apache/cloudstack/pull/1636
Fix a quote issue with Spanish L10N (from transifex translation)
This fix is for the 4.8 branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack L10N-update-4.8-20160812-fix-spanish-quote
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1636
----
commit 6df5df569423182fc62bf378dd32166a0ab55c9d
Author: Milamber <mi...@apache.org>
Date: 2016-08-12T06:13:44Z
Fix a quote issue with Spanish L10N (from transifex translation)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@milamberspace I am trying to get this PR merged, but am running into some issues the git-pr script. I am working with @rhtyd to figure out what I am doing wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@jburwell I repush with force, but the build error still alive on Travis
"========> Processing SQL file at /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql
Unable to execute /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql: Unknown column 'state' in 'field list'"
I suppose it's an issue on 4.8 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
Posted by milamberspace <gi...@git.apache.org>.
GitHub user milamberspace reopened a pull request:
https://github.com/apache/cloudstack/pull/1636
Fix a quote issue with Spanish L10N (from transifex translation)
This fix is for the 4.8 branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack L10N-update-4.8-20160812-fix-spanish-quote
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1636
----
commit 6df5df569423182fc62bf378dd32166a0ab55c9d
Author: Milamber <mi...@apache.org>
Date: 2016-08-12T06:13:44Z
Fix a quote issue with Spanish L10N (from transifex translation)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@rhtyd do you any insight about the database schema issue @milamberspace is encountering in the Travis build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1636
Thanks for reply @rhtyd I will wait the merge of #1654 before force to re-check this PR by travis/jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1636
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@milamberspace could you add a JIRA ticket for this issue and prefix the title of the commit message and PR title with the ID?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@milamberspace the Jenkins build build failed. Could you please force push the change to trigger another attempt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@jburwell @rhtyd Since #1654 has been merged. Travis and Jenkins tests have passed. Ready to merge this small PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@jburwell @milamberspace due to version change in poms already merged on 4.8 without a valid db upgrade path (which I had added in a separate PR), we'll see db failures for all PRs targeting 4.8 branch. Please fix and merge #1654 first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---