[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r304552979
 
 

 ##########
 File path: libminifi/include/utils/HTTPClient.h
 ##########
 @@ -66,37 +69,89 @@ struct HTTPReadCallback {
   }
 };
 
+enum class SSLVersion : uint8_t {
+  SSLv2,
+  SSLv3,
+  TLSv1_0,
+  TLSv1_1,
+  TLSv1_2,
+};
+
 struct HTTPHeaderResponse {
  public:
-
   HTTPHeaderResponse(int max)
-      : max_tokens_(max) {
+   : max_tokens_(max)
+   , parsed(false) {
   }
 
-  void append(const std::string &header) {
+  DEPRECATED void append(const std::string &header) {
 
 Review comment:
   Can  you add a comment on when this was deprecated so that we can do it in a timely manner since we are coming to the close of 0.x we should probably remove this after 1.0. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services