You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/25 20:52:04 UTC
[jira] [Commented] (BEAM-2365) Use highest protocol for pickle
coder.
[ https://issues.apache.org/jira/browse/BEAM-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025376#comment-16025376 ]
ASF GitHub Bot commented on BEAM-2365:
--------------------------------------
GitHub user robertwb opened a pull request:
https://github.com/apache/beam/pull/3226
[BEAM-2365] Use the highest pickle protocol available.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam pickle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3226
----
commit a2a5353f348c3c42ccf7b560a8c8dee42e21f035
Author: Robert Bradshaw <ro...@gmail.com>
Date: 2017-05-25T20:49:48Z
[BEAM-2365] Use the highest pickle protocol available.
----
> Use highest protocol for pickle coder.
> --------------------------------------
>
> Key: BEAM-2365
> URL: https://issues.apache.org/jira/browse/BEAM-2365
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
>
> E.g. for large NumPy arrays, this is a 3x reduction in size and a 61x reduction in cpu.
> Note that dill already does this (but the FastPrimitivesCoder intentionally uses cPickle instead).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)