You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2009/03/02 06:53:12 UTC
[jira] Commented: (HADOOP-4638) Exception thrown in/from
RecoveryManager.recover() should be caught and handled
[ https://issues.apache.org/jira/browse/HADOOP-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677896#action_12677896 ]
Amareshwari Sriramadasu commented on HADOOP-4638:
-------------------------------------------------
Framework changes look good.
Some comments in Testcase:
1. testJobTracker() does not have any assertion in the test.
2. Comments for testRecoveryManager() look different from implementation. Also can you add the assertion that Job1 is ignored and Job2 succeeded?
> Exception thrown in/from RecoveryManager.recover() should be caught and handled
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4638
> URL: https://issues.apache.org/jira/browse/HADOOP-4638
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-4638-v1.1.patch, HADOOP-4638-v1.3.patch, HADOOP-4638-v1.6.patch, HADOOP-4638-v1.8.patch
>
>
> {{RecoveryManager.recover()}} can throw an exception while recovering a job. Since the {{JobTracker}} calls {{RecoveryManager.recover()}} from {{offerService()}}, any failure in recovery will cause {{JobTracker}} to crash. Ideally the {{RecoveryManager}} should log the failure encountered while recovering the job and continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.