You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/16 02:13:48 UTC

[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #21: Demonstrate vendoring + symbol renaming

paleolimbot commented on issue #21:
URL: https://github.com/apache/arrow-nanoarrow/issues/21#issuecomment-1216064759

   I was thinking that an `examples/` directory should exist...this should definitely be one of them!
   
   With respect to symbol renaming, I've only seen this in H3: https://github.com/uber/h3/blob/master/src/h3lib/include/h3api.h.in#L27-L50 . Should we do that here or is there another thing I should be using? Privately linking to a static library should also work, correct?
   
   One could also use external function declarations as `NANOARROW_DLL void ArrowSomething();`, which might allow something like `#define NANOARROW_DLL static (inline?)` to get a header-only version? I don't want to go too crazy on the `#define` options because I find that kind of thing annoying when other libraries do it, but that one seems like it might allow some flexibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org