You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Aleksandar Bircakovic <a....@levi9.com> on 2015/10/08 14:52:30 UTC
Review Request 39130: SAMZA-791 KafkaSystemFactory narrows return
types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39130/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
Specified return types for methods in KafkaSystemFactory.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala d84bf06
Diff: https://reviews.apache.org/r/39130/diff/
Testing
-------
./gradlew clean build
Thanks,
Aleksandar Bircakovic
Re: Review Request 39130: SAMZA-791 KafkaSystemFactory narrows return
types
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39130/#review102207
-----------------------------------------------------------
Ship it!
+1. LGTM. Thanks!
- Yi Pan (Data Infrastructure)
On Oct. 8, 2015, 12:52 p.m., Aleksandar Bircakovic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39130/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 12:52 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Specified return types for methods in KafkaSystemFactory.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala d84bf06
>
> Diff: https://reviews.apache.org/r/39130/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Aleksandar Bircakovic
>
>