You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/10/29 22:01:30 UTC

Review Request 39772: Sqoop2: Ensure that classpath loading integration tests are run by default

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39772/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2645
    https://issues.apache.org/jira/browse/SQOOP-2645


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Ensure that classpath loading integration tests are run by default


Diffs
-----

  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java f60695003284d32d94c6d3fd7fb992dabd3849b7 
  test/pom.xml ad8cd11f723f2b4852adb0bea807620f93e55e4b 
  test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 2d6d37f938048932667ad186ba3e483c0c81cb14 
  test/src/test/resources/classpath-tests-suite.xml  

Diff: https://reviews.apache.org/r/39772/diff/


Testing
-------

yes


Thanks,

Abraham Fine


Re: Review Request 39772: Sqoop2: Ensure that classpath loading integration tests are run by default

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39772/#review104489
-----------------------------------------------------------

Ship it!


(As long as precommit hook will pass)

- Jarek Cecho


On Oct. 29, 2015, 9:01 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39772/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 9:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2645
>     https://issues.apache.org/jira/browse/SQOOP-2645
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Ensure that classpath loading integration tests are run by default
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java f60695003284d32d94c6d3fd7fb992dabd3849b7 
>   test/pom.xml ad8cd11f723f2b4852adb0bea807620f93e55e4b 
>   test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 2d6d37f938048932667ad186ba3e483c0c81cb14 
>   test/src/test/resources/classpath-tests-suite.xml  
> 
> Diff: https://reviews.apache.org/r/39772/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>


Re: Review Request 39772: Sqoop2: Ensure that classpath loading integration tests are run by default

Posted by Abraham Fine <ab...@brightroll.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39772/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 1:29 a.m.)


Review request for Sqoop.


Bugs: SQOOP-2645
    https://issues.apache.org/jira/browse/SQOOP-2645


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Ensure that classpath loading integration tests are run by default


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java f60695003284d32d94c6d3fd7fb992dabd3849b7 
  test/pom.xml ad8cd11f723f2b4852adb0bea807620f93e55e4b 
  test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 2d6d37f938048932667ad186ba3e483c0c81cb14 
  test/src/test/resources/classpath-tests-suite.xml  

Diff: https://reviews.apache.org/r/39772/diff/


Testing
-------

yes


Thanks,

Abraham Fine