You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:29:54 UTC
[GitHub] [superset] villebro opened a new pull request, #19972: Revert "chore(deps): bump d3-svg-legend in /superset-frontend (#19846)"
villebro opened a new pull request, #19972:
URL: https://github.com/apache/superset/pull/19972
### SUMMARY
`d3-svg-legend` version 2 is incompatible with `d3` version 3 (see: https://github.com/susielu/d3-legend/issues/58). I contemplated the option of bumping `d3` to version 4, but decided against it due to the following reasons:
- The API has been totally overhauled in `d3` version 4 and would have required fairly big changes
- `d3` is now on version 7
- `d3-svg-legend` has been stale for 4 years
Instead I think we should just migrate this plugin to `d3` version 7 or the equivalent ECharts version (https://echarts.apache.org/examples/en/editor.html?c=heatmap-cartesian) while migrating this plugin to the v1 chart data endpoint.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19972: fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19972:
URL: https://github.com/apache/superset/pull/19972#issuecomment-1119423112
> LGTM! Let's migrate to Echarts version next!
Agreed @stephenLYZ , it seems like a perfect drop in replacement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19972: fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19972:
URL: https://github.com/apache/superset/pull/19972#issuecomment-1119406630
LGTM! Let's migrate to Echarts version next!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19972: revert: chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19972:
URL: https://github.com/apache/superset/pull/19972#issuecomment-1119289261
# [Codecov](https://codecov.io/gh/apache/superset/pull/19972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19972](https://codecov.io/gh/apache/superset/pull/19972?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (127754c) into [master](https://codecov.io/gh/apache/superset/commit/7b5ba390296a423c83c36b2658956fd4b6c6180b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b5ba39) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 127754c differs from pull request most recent head fe713c8. Consider uploading reports for the commit fe713c8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19972 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 1712 1712
Lines 63962 63962
Branches 6731 6731
=======================================
Hits 42404 42404
Misses 19847 19847
Partials 1711 1711
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.28% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19972?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19972?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b5ba39...fe713c8](https://codecov.io/gh/apache/superset/pull/19972?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #19972: fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Posted by GitBox <gi...@apache.org>.
villebro merged PR #19972:
URL: https://github.com/apache/superset/pull/19972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org