You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2025/08/07 15:55:32 UTC

[PR] Use copy_props in the compactor instead of set_props [couchdb]

nickva opened a new pull request, #5620:
URL: https://github.com/apache/couchdb/pull/5620

   Previously, compactor used set_props/2 instead of copy_props/2. The difference is set_props/2 also advances the update sequence, while copy_props/2 doesn't. However, we should not do that when we copy security and props in the compactor. In this case it turned to be a benign issue since immediately after the update sequence is reset anyway to the one from the old state the following snippet:
   
   ```
       FinalUpdateSeq = couch_bt_engine:get_update_seq(St)
       {ok, NewSt6} = couch_bt_engine:set_update_seq(NewSt5, FinalUpdateSeq)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use copy_props in the compactor instead of set_props [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5620:
URL: https://github.com/apache/couchdb/pull/5620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org