[GitHub] liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160069258
 
 

 ##########
 File path: spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseDiscoveryClientConfiguration.java
 ##########
 @@ -17,33 +17,17 @@
 package io.servicecomb.springboot.starter.discovery;
 
 import org.springframework.boot.autoconfigure.AutoConfigureBefore;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.cloud.client.discovery.DiscoveryClient;
 import org.springframework.cloud.client.discovery.noop.NoopDiscoveryClientAutoConfiguration;
-import org.springframework.cloud.netflix.zuul.filters.ZuulProperties;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Primary;
-
-import io.servicecomb.core.provider.consumer.ConsumerProviderManager;
+import org.springframework.core.annotation.Order;
 
 @AutoConfigureBefore(NoopDiscoveryClientAutoConfiguration.class)
 @Configuration
 public class CseDiscoveryClientConfiguration {
-
-  @Bean
-  public CseDiscoveryProperties cseDiscoveryProperties() {
-    return new CseDiscoveryProperties();
-  }
-
-  @Bean
-  @ConditionalOnBean(ZuulProperties.class)
-  public CseRoutesProperties cseRoutesProperties(ConsumerProviderManager manager) {
-    return new CseRoutesProperties(manager);
-  }
-
   @Bean
-  @Primary
+  @Order(5000)
 
 Review comment:
   Yes. Spring cloud provide a composite DiscoveryClient as Primary, we can't use this as primary and this will cause corruption.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services