[jira] [Commented] (CALCITE-5279) Asymmetric keyword not supported by Firebolt

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622490#comment-17622490 ] 

Julian Hyde commented on CALCITE-5279:
--------------------------------------

I reviewed the PR. The code in {{FireboltSqlDialect}} would benefit from a simple comment describing the rewrite.

Are you simply removing the {{ASYMMETRIC}} keyword? If so, are you sure that that's valid?

Would it be possible to rewrite by creating a {{SqlCall}} that does not have {{ASYMMETRIC}}? Then I believe you will eliminate a lot of messy code like making {{AndFinder}} public.

> Asymmetric keyword not supported by Firebolt
> --------------------------------------------
>
>                 Key: CALCITE-5279
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5279
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.31.0, 1.32.0
>            Reporter: Aymeric Dispa
>            Assignee: Aymeric Dispa
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.33.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Asymmetric keyword is not supported by Firebolt.
> The dialect must be changed so that the keyword that is not supported is simply not included in the query



--
This message was sent by Atlassian Jira
(v8.20.10#820010)