You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by millayr <gi...@git.apache.org> on 2017/03/03 20:58:58 UTC

[GitHub] couchdb-fauxton pull request #865: Permanent Notification Banner Plugin

GitHub user millayr opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/865

    Permanent Notification Banner Plugin

    This PR gives us the option to dynamically set a notification banner across the top of fauxton.
    
    For example:
    ![image](https://cloud.githubusercontent.com/assets/6378840/23568793/39fcdf36-002a-11e7-8769-4cee2a1d8f90.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/millayr/couchdb-fauxton perma-warning-header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #865
    
----
commit 7902254be9b4891682a5da4b20ef102a6b3eab4a
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T18:53:42Z

    initialize perma warning progress

commit 0494e23060ce5e186b2f91f222a2b8396460b879
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T20:28:50Z

    tweaking styling and layout

commit 93119de9f3e20acee584b1a275132e8badb809db
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T20:46:18Z

    adding permanent notification test

commit 9c61fda0b7e258b06b32c295ffa2596f08a64fd7
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T20:47:56Z

    adding new line chars

commit 273e85ce07b00e86e767b4130885d491dee59a2a
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T20:50:04Z

    cleaning test

commit 84931845c98f5bebe927646dc72b2b5bfe4099c9
Author: Ryan Millay <ry...@gmail.com>
Date:   2017-03-03T20:51:20Z

    fixing identation to spaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request #865: Permanent Notification Banner Plugin

Posted by millayr <gi...@git.apache.org>.
Github user millayr closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/865


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #865: Permanent Notification Banner Plugin

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:

    https://github.com/apache/couchdb-fauxton/pull/865
  
    Awesome. This has been merged. You can close the ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #865: Permanent Notification Banner Plugin

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:

    https://github.com/apache/couchdb-fauxton/pull/865
  
    This looks good. There doesn't seem to be a way to clear the notification. 
    Could you fix the linting issues. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---