You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/26 05:59:47 UTC
[GitHub] [doris] AshinGau opened a new pull request, #15358: [fix](multi-catalog) throw NPE when reading data after EOF
AshinGau opened a new pull request, #15358:
URL: https://github.com/apache/doris/pull/15358
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1364949709
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1364926246
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1365106792
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15358:
URL: https://github.com/apache/doris/pull/15358#discussion_r1057081742
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -57,7 +57,7 @@ Status RowGroupReader::init(const FieldDescriptor& schema, std::vector<RowRange>
for (auto& read_col : _read_columns) {
auto field = const_cast<FieldSchema*>(schema.get_column(read_col._file_slot_name));
std::unique_ptr<ParquetColumnReader> reader;
- RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field, read_col, _row_group_meta,
+ RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field, _row_group_meta,
Review Comment:
warning: no viable conversion from 'io::FileReaderSPtr' (aka 'shared_ptr<doris::io::FileReader>') to 'doris::FileReader *' [clang-diagnostic-error]
```cpp
RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field, _row_group_meta,
^
```
**be/src/common/status.h:484:** expanded from macro 'RETURN_IF_ERROR'
```cpp
Status _status_ = (stmt); \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.h:109:** passing argument to parameter 'file' here
```cpp
static Status create(FileReader* file, FieldSchema* field, const tparquet::RowGroup& row_group,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1365106872
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1365080195
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.7 seconds
load time: 694 seconds
storage size: 17123400441 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221226105030_clickbench_pr_68829.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1364949689
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15358:
URL: https://github.com/apache/doris/pull/15358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1365010904
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15358: [fix](multi-catalog) throw NPE when reading data after EOF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15358:
URL: https://github.com/apache/doris/pull/15358#issuecomment-1364927284
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org