You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@continuum.apache.org by "edward grey (JIRA)" <ji...@codehaus.org> on 2013/01/31 09:03:13 UTC
[jira] (CONTINUUM-2702) Cannot add an argument to remove a profile
( -P!profile)
edward grey created CONTINUUM-2702:
--------------------------------------
Summary: Cannot add an argument to remove a profile ( -P!profile)
Key: CONTINUUM-2702
URL: https://jira.codehaus.org/browse/CONTINUUM-2702
Project: Continuum
Issue Type: Bug
Components: Web interface, XMLRPC Interface
Affects Versions: 1.4.1
Environment: All
Reporter: edward grey
I've a maven profile 'dev' in my project for local configuration.
When I build my project, I want to remove the dev profile. maven provides the -P!dev command. In continuum version 1.3.4, adding this attribute was OK.
In v1.4.1, there is an error ('!' detected as invalid character).
To fix this, we should add '!' in the list of accepted character in 3 files :
continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml
continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/admin/BuildDefinitionTemplateAction-saveBuildDefinitionAsTemplate-validation.xml
continuum/trunk/continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
In this 3 files, the argument validation pattern should accept '!'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (CONTINUUM-2702) Cannot add an argument to remove a profile
( -P!profile)
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/CONTINUUM-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318703#comment-318703 ]
Brett Porter commented on CONTINUUM-2702:
-----------------------------------------
Thanks for reporting this, some of the validations are certainly too aggressive. Do you mind submitting this fix in patch format, with tests to verify it to ensure that it is not lost in future? You'll find examples of other validations rules in the projects mentioned and continuum-webapp-test
> Cannot add an argument to remove a profile ( -P!profile)
> ---------------------------------------------------------
>
> Key: CONTINUUM-2702
> URL: https://jira.codehaus.org/browse/CONTINUUM-2702
> Project: Continuum
> Issue Type: Bug
> Components: Web interface, XMLRPC Interface
> Affects Versions: 1.4.1
> Environment: All
> Reporter: edward grey
> Fix For: 1.4.2
>
>
> I've a maven profile 'dev' in my project for local configuration.
> When I build my project, I want to remove the dev profile. maven provides the -P!dev command. In continuum version 1.3.4, adding this attribute was OK.
> In v1.4.1, there is an error ('!' detected as invalid character).
> To fix this, we should add '!' in the list of accepted character in 3 files :
> continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml
> continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/admin/BuildDefinitionTemplateAction-saveBuildDefinitionAsTemplate-validation.xml
> continuum/trunk/continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
> In this 3 files, the argument validation pattern should accept '!'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (CONTINUUM-2702) Cannot add an argument to remove a profile
( -P!profile)
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/CONTINUUM-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated CONTINUUM-2702:
------------------------------------
Fix Version/s: 1.4.2
> Cannot add an argument to remove a profile ( -P!profile)
> ---------------------------------------------------------
>
> Key: CONTINUUM-2702
> URL: https://jira.codehaus.org/browse/CONTINUUM-2702
> Project: Continuum
> Issue Type: Bug
> Components: Web interface, XMLRPC Interface
> Affects Versions: 1.4.1
> Environment: All
> Reporter: edward grey
> Fix For: 1.4.2
>
>
> I've a maven profile 'dev' in my project for local configuration.
> When I build my project, I want to remove the dev profile. maven provides the -P!dev command. In continuum version 1.3.4, adding this attribute was OK.
> In v1.4.1, there is an error ('!' detected as invalid character).
> To fix this, we should add '!' in the list of accepted character in 3 files :
> continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml
> continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/admin/BuildDefinitionTemplateAction-saveBuildDefinitionAsTemplate-validation.xml
> continuum/trunk/continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
> In this 3 files, the argument validation pattern should accept '!'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira