[jira] [Commented] (HIVE-2629) Make a single Hive binary work with both 0.20.x and 0.23.0

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181185#comment-13181185 ] 

Phabricator commented on HIVE-2629:
-----------------------------------

amareshwarisr has commented on the revision "HIVE-2629 [jira] Make a single Hive binary work with both 0.20.x and 0.23.0".

  The directory commonSecure should be changed to common/secure. Why don't we put those files in the directory common itself? Why create a new directory? Putting them in common would make the code cleaner


INLINE COMMENTS
  build-common.xml:118-123 Why are these changes required? If not required, can you remove them?
  build.properties:13-17 Are we going to add new version here for all the upcoming versions as well?  I don't think we should do it this way.
  shims/build.xml:57 Can we change commonSecure to common.secure in all the places?

REVISION DETAIL
  https://reviews.facebook.net/D711

                
> Make a single Hive binary work with both 0.20.x and 0.23.0
> ----------------------------------------------------------
>
>                 Key: HIVE-2629
>                 URL: https://issues.apache.org/jira/browse/HIVE-2629
>             Project: Hive
>          Issue Type: Bug
>          Components: Shims
>            Reporter: Carl Steinbach
>            Assignee: Thomas Weise
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2629.D711.1.patch, HIVE-2629.D711.2.patch, HIVE-2629.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira