You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2020/02/14 20:33:02 UTC
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15223
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
IMPALA-9287 adds the capability to start Impala cluster with an embedded
HMS. However, it adds a dependency of hive-metastore to the hive-3
profile which is unnecessary since we already have
standalone-hive-metastore.
Adding hive-metastore is not recommended since it brings along with it
hive-serde as well which has a conflicting version of flatbuffers. This
causes table loading errors on the catalog side.
Testing:
1. Ran test_kudu_table_create_without_hms.py
2. Running core tests with CDP build.
Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
---
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
2 files changed, 2 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15223/2
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
IMPALA-9287 adds the capability to start Impala cluster with an embedded
HMS. However, it adds a dependency of hive-metastore to the hive-3
profile which is unnecessary since we already have
standalone-hive-metastore.
Adding hive-metastore is not recommended since it brings along with it
hive-serde as well which has a conflicting version of flatbuffers. This
causes table loading errors on the catalog side.
Testing:
1. Ran test_kudu_table_create_without_hms.py
2. Running core tests with CDP build.
Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15223/4
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
Patch Set 4:
> Abandon this?
Actually, this patch is still need to re-enable IMPALA-9287
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 17:46:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
IMPALA-9287: Add support for embedded metastore mode
This is an update to the earlier patch which was reverted for
IMPALA-9287. The original patch added dependency to hive-metastore
module in hive-3 profile which was unnecessary since we already have
a dependency to standalone-hive-metastore module.
Adding hive-metastore is not recommended since it brings along with
it hive-serde as well which has a conflicting version of flatbuffers.
This causes table loading errors on the catalog side.
Testing:
1. Ran test_kudu_table_create_without_hms.py
2. [WIP] Running core tests with CDP build.
Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
---
M .gitignore
M bin/bootstrap_system.sh
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
5 files changed, 42 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15223/7
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
IMPALA-9287: Add support for embedded metastore mode
This is an update to the earlier patch which was reverted for
IMPALA-9287. The original patch added dependency to hive-metastore
module in hive-3 profile which was unnecessary since we already have
a dependency to standalone-hive-metastore module.
Adding hive-metastore is not recommended since it brings along with
it hive-serde as well which has a conflicting version of flatbuffers.
This causes table loading errors on the catalog side.
Testing:
1. Ran test_kudu_table_create_without_hms.py
2. [WIP] Running core tests with CDP build.
Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15223/5
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
Patch Set 2:
> The IMPALA-9287 change is also showing test failures on
> USE_CDP_HIVE=true. TestCreatingKuduTableWithoutHMS is failing and
> causing other custom cluster tests to fail. I prefer to do a quick
> revert of that change rather than trying to fix it in place. We
> don't know what else could be broken.
Submitted a separate change http://gerrit.cloudera.org:8080/15227 to revert the original patch.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Feb 2020 22:45:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5288/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 18:32:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has abandoned this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
Abandoned
I am not actively working on this patch anymore.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
Patch Set 2:
The IMPALA-9287 change is also showing test failures on USE_CDP_HIVE=true. TestCreatingKuduTableWithoutHMS is failing and causing other custom cluster tests to fail. I prefer to do a quick revert of that change rather than trying to fix it in place. We don't know what else could be broken.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Feb 2020 21:25:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
Patch Set 2:
Abandon this?
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 07:56:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5227/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Feb 2020 21:18:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5305/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 23:14:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 )
Change subject: IMPALA-9287: Add support for embedded metastore mode
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5289/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7de6a7f11ef0bff85c0fb03f004756c3cde784
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 18:38:25 +0000
Gerrit-HasComments: No