You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/09/09 12:07:30 UTC
Review Request 38212: LENS-392: Look ahead should take how much time
to look ahead, instead of just a number
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java f192463dc2d32d9a783495ef299869a56281cc15
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f81f3d5975d8604743050d1a5c106039007f871f
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java aab24887ba9191612bd34f9169f2e8fd101ea95d
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 450d17202d7a06214ecd997d4bab68fe8351ab3e
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java cbcc76c56daf8c225ab2fcdef905ef37918f9952
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 1a347b2e53022c6182430473def3e5c537d32817
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java c7f1e2a15a5e31d1444930671fedc1a9d75ecf3e
lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 82410d3cf77735af82605200b73519c398416a79
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 7be7ace884bb843604934f650c656e326767b7e3
lens-cube/src/main/java/org/apache/lens/cube/time/TimeDiff.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java ab88fbe067fadc839676f0013dc4885e3fbc5546
lens-cube/src/test/java/org/apache/lens/cube/time/TimeDiffTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/38212/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 6:22 p.m.)
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java f5f8d4c8ec4177b2d83f5f567386a0422958c69d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 7f5629200f82f92e00fccd423097666383b06e18
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.285s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [21.064s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
[INFO] Lens Cube ......................................... SUCCESS [5:27.193s]
[INFO] Lens DB storage ................................... SUCCESS [18.947s]
[INFO] Lens Query Library ................................ SUCCESS [16.214s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.010s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.208s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.168s]
[INFO] Lens Server ....................................... SUCCESS [5:37.934s]
[INFO] Lens client ....................................... SUCCESS [38.626s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.371s]
[INFO] Lens Examples ..................................... SUCCESS [8.829s]
[INFO] Lens Distribution ................................. SUCCESS [9.163s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.146s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.040s]
[INFO] Lens Regression ................................... SUCCESS [10.560s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:25.417s
[INFO] Finished at: Mon Sep 14 12:59:16 UTC 2015
[INFO] Final Memory: 194M/2078M
[INFO] ------------------------------------------------------------------------
Added a test case
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/#review99009
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Sept. 14, 2015, 1:05 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38212/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 1:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-392
> https://issues.apache.org/jira/browse/LENS-392
>
>
> Repository: lens
>
>
> Description
> -------
>
> e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java f5f8d4c8ec4177b2d83f5f567386a0422958c69d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 7f5629200f82f92e00fccd423097666383b06e18
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
>
> Diff: https://reviews.apache.org/r/38212/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.285s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [21.064s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
> [INFO] Lens Cube ......................................... SUCCESS [5:27.193s]
> [INFO] Lens DB storage ................................... SUCCESS [18.947s]
> [INFO] Lens Query Library ................................ SUCCESS [16.214s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.010s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.208s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.168s]
> [INFO] Lens Server ....................................... SUCCESS [5:37.934s]
> [INFO] Lens client ....................................... SUCCESS [38.626s]
> [INFO] Lens CLI .......................................... SUCCESS [2:39.371s]
> [INFO] Lens Examples ..................................... SUCCESS [8.829s]
> [INFO] Lens Distribution ................................. SUCCESS [9.163s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.146s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.040s]
> [INFO] Lens Regression ................................... SUCCESS [10.560s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:25.417s
> [INFO] Finished at: Mon Sep 14 12:59:16 UTC 2015
> [INFO] Final Memory: 194M/2078M
> [INFO] ------------------------------------------------------------------------
>
> Added a test case
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 6:35 p.m.)
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java f5f8d4c8ec4177b2d83f5f567386a0422958c69d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 7f5629200f82f92e00fccd423097666383b06e18
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.285s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [21.064s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
[INFO] Lens Cube ......................................... SUCCESS [5:27.193s]
[INFO] Lens DB storage ................................... SUCCESS [18.947s]
[INFO] Lens Query Library ................................ SUCCESS [16.214s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.010s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.208s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.168s]
[INFO] Lens Server ....................................... SUCCESS [5:37.934s]
[INFO] Lens client ....................................... SUCCESS [38.626s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.371s]
[INFO] Lens Examples ..................................... SUCCESS [8.829s]
[INFO] Lens Distribution ................................. SUCCESS [9.163s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.146s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.040s]
[INFO] Lens Regression ................................... SUCCESS [10.560s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:25.417s
[INFO] Finished at: Mon Sep 14 12:59:16 UTC 2015
[INFO] Final Memory: 194M/2078M
[INFO] ------------------------------------------------------------------------
Added a test case
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 6:09 p.m.)
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java f5f8d4c8ec4177b2d83f5f567386a0422958c69d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 7f5629200f82f92e00fccd423097666383b06e18
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
[INFO] Lens .............................................. SUCCESS [3.155s]
[INFO] Lens API .......................................... SUCCESS [24.053s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
[INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
[INFO] Lens DB storage ................................... SUCCESS [19.195s]
[INFO] Lens Query Library ................................ SUCCESS [15.957s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
[INFO] Lens Server ....................................... SUCCESS [5:36.155s]
[INFO] Lens client ....................................... SUCCESS [38.194s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
[INFO] Lens Examples ..................................... SUCCESS [8.489s]
[INFO] Lens Distribution ................................. SUCCESS [8.929s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
[INFO] Lens Regression ................................... SUCCESS [10.544s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:29.260s
[INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
[INFO] Final Memory: 193M/1888M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 1:44 p.m.)
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
[INFO] Lens .............................................. SUCCESS [3.155s]
[INFO] Lens API .......................................... SUCCESS [24.053s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
[INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
[INFO] Lens DB storage ................................... SUCCESS [19.195s]
[INFO] Lens Query Library ................................ SUCCESS [15.957s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
[INFO] Lens Server ....................................... SUCCESS [5:36.155s]
[INFO] Lens client ....................................... SUCCESS [38.194s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
[INFO] Lens Examples ..................................... SUCCESS [8.489s]
[INFO] Lens Distribution ................................. SUCCESS [8.929s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
[INFO] Lens Regression ................................... SUCCESS [10.544s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:29.260s
[INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
[INFO] Final Memory: 193M/1888M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Sept. 11, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 632
> > <https://reviews.apache.org/r/38212/diff/2/?file=1068107#file1068107line632>
> >
> > Should both flags be false here?
Perhaps the argument names might need changing, values are correct I think. This combination doesn't break existing functionality and enables look ahead to be correct. There was an existing check in the code to add the partitions if the flags are true and false.
> On Sept. 11, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 1337
> > <https://reviews.apache.org/r/38212/diff/2/?file=1068108#file1068108line1337>
> >
> > Why is 1 day look ahead is not doing anything?
because the next day's pt columns are found. So if under that, current day's it exists, it would have alredy been covered.
> On Sept. 11, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 1360
> > <https://reviews.apache.org/r/38212/diff/2/?file=1068108#file1068108line1360>
> >
> > Can we add asserts for both testcube.pt and testcube.it ?
> >
> > Is it possible to add atleast one time value to the assert? If yes, then we can remove compareQueries() and these asserts should be sufficient.
The values will depend on the actual partitions in the table. And that's dependent on the time the test is run. I think finding a pattern there would be difficult. I'll see if I can find one.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/#review98580
-----------------------------------------------------------
On Sept. 11, 2015, 12:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38212/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 12:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-392
> https://issues.apache.org/jira/browse/LENS-392
>
>
> Repository: lens
>
>
> Description
> -------
>
> e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
>
> Diff: https://reviews.apache.org/r/38212/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
> [INFO] Lens .............................................. SUCCESS [3.155s]
> [INFO] Lens API .......................................... SUCCESS [24.053s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
> [INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
> [INFO] Lens DB storage ................................... SUCCESS [19.195s]
> [INFO] Lens Query Library ................................ SUCCESS [15.957s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.155s]
> [INFO] Lens client ....................................... SUCCESS [38.194s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
> [INFO] Lens Examples ..................................... SUCCESS [8.489s]
> [INFO] Lens Distribution ................................. SUCCESS [8.929s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
> [INFO] Lens Regression ................................... SUCCESS [10.544s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:29.260s
> [INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
> [INFO] Final Memory: 193M/1888M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/#review98580
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 632)
<https://reviews.apache.org/r/38212/#comment155100>
Should both flags be false here?
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 1337)
<https://reviews.apache.org/r/38212/#comment155101>
Why is 1 day look ahead is not doing anything?
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 1360)
<https://reviews.apache.org/r/38212/#comment155102>
Can we add asserts for both testcube.pt and testcube.it ?
Is it possible to add atleast one time value to the assert? If yes, then we can remove compareQueries() and these asserts should be sufficient.
- Amareshwari Sriramadasu
On Sept. 11, 2015, 7:06 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38212/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:06 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-392
> https://issues.apache.org/jira/browse/LENS-392
>
>
> Repository: lens
>
>
> Description
> -------
>
> e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
>
> Diff: https://reviews.apache.org/r/38212/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
> [INFO] Lens .............................................. SUCCESS [3.155s]
> [INFO] Lens API .......................................... SUCCESS [24.053s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
> [INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
> [INFO] Lens DB storage ................................... SUCCESS [19.195s]
> [INFO] Lens Query Library ................................ SUCCESS [15.957s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.155s]
> [INFO] Lens client ....................................... SUCCESS [38.194s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
> [INFO] Lens Examples ..................................... SUCCESS [8.489s]
> [INFO] Lens Distribution ................................. SUCCESS [8.929s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
> [INFO] Lens Regression ................................... SUCCESS [10.544s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:29.260s
> [INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
> [INFO] Final Memory: 193M/1888M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 38212: LENS-392: Look ahead not working when not
all process time partitions on lower granularity are present
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 12:36 p.m.)
Review request for lens.
Summary (updated)
-----------------
LENS-392: Look ahead not working when not all process time partitions on lower granularity are present
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description (updated)
-------
e.g. for a monthly query with look ahead = 1, if next month partition is not present, it looks for process time partitions for all days of the next month. And all of them might not be present. So we should proceed with whichever ones are present.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
[INFO] Lens .............................................. SUCCESS [3.155s]
[INFO] Lens API .......................................... SUCCESS [24.053s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
[INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
[INFO] Lens DB storage ................................... SUCCESS [19.195s]
[INFO] Lens Query Library ................................ SUCCESS [15.957s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
[INFO] Lens Server ....................................... SUCCESS [5:36.155s]
[INFO] Lens client ....................................... SUCCESS [38.194s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
[INFO] Lens Examples ..................................... SUCCESS [8.489s]
[INFO] Lens Distribution ................................. SUCCESS [8.929s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
[INFO] Lens Regression ................................... SUCCESS [10.544s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:29.260s
[INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
[INFO] Final Memory: 193M/1888M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 38212: LENS-392: Look ahead should take how much
time to look ahead, instead of just a number
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38212/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 12:27 p.m.)
Review request for lens.
Bugs: LENS-392
https://issues.apache.org/jira/browse/LENS-392
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java fc2d85b89e9809a61c982ca78a7d18ffacee76f6
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java d52f1686254ab0b9c977af84731888778edacb8a
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 2caea569a6af1f717bef49491b024441808b5448
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7e5184c472b230cbee0c633191283a0368a82949
Diff: https://reviews.apache.org/r/38212/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s]
[INFO] Lens .............................................. SUCCESS [3.155s]
[INFO] Lens API .......................................... SUCCESS [24.053s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.270s]
[INFO] Lens Cube ......................................... SUCCESS [5:33.467s]
[INFO] Lens DB storage ................................... SUCCESS [19.195s]
[INFO] Lens Query Library ................................ SUCCESS [15.957s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s]
[INFO] Lens Server ....................................... SUCCESS [5:36.155s]
[INFO] Lens client ....................................... SUCCESS [38.194s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.445s]
[INFO] Lens Examples ..................................... SUCCESS [8.489s]
[INFO] Lens Distribution ................................. SUCCESS [8.929s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s]
[INFO] Lens Regression ................................... SUCCESS [10.544s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:29.260s
[INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
[INFO] Final Memory: 193M/1888M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal