You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/01 02:51:00 UTC
[GitHub] [druid] vogievetsky opened a new pull request, #13013: Web console: don't crash if cookies are totally disabled
vogievetsky opened a new pull request, #13013:
URL: https://github.com/apache/druid/pull/13013
So I was reading this blog post: https://blog.tomayac.com/2022/08/30/things-not-available-when-someone-blocks-all-cookies/
And I wondered what would happen to the web console if I disabled the cookies in chrome. Turns out it crashes because even doing `typeof localStorage === 'undefined'` throws an exception.
Also made the numeric input dialog be able to represent not having any state selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #13013: Web console: don't crash if cookies are totally disabled
Posted by GitBox <gi...@apache.org>.
gianm merged PR #13013:
URL: https://github.com/apache/druid/pull/13013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org