You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org> on 2007/03/06 12:29:24 UTC
[jira] Commented: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478373 ]
Henning Schmiedehausen commented on VELOCITY-521:
-------------------------------------------------
Enforcing the version of the compiler might be good to catch errors on the release manager side, however it makes a PITA for anyone that wants to build the release for internal purposes. There are good reasons (we actually recommend it in the README IIRC) to rebuild with 1.3 if you are stuck in a legacy environment.
I'd suggest to back that patch out from build.xml and add an internal, non-commented (so that it does not show up in "ant -p") target, e.g. dist-package, that is used by the release manager to build the distribution.
I also would like to see this clearly documented in the velocity docs.
That is the kind of "last minute rush" patches, that I did want to avoid. That patch should IMHO not have been in the 1.5 release, that would have been good for 1.5.1 or 1.6
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assigned To: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org