You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/17 16:48:48 UTC

[GitHub] [incubator-echarts] 100pah commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect

100pah commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-711044389


   @pissang @susiwen8 
   This animation is correct in 4.9.
   But there is a mistake when refactor it from `position` to `xy` in 5.0.
   
   The reason of `contentPos`: 
   in case that the elements inside `contentGroup` are layout not based on `[0, 0]`.  (for example, the left-top displayable part is at `[-0.5, -0.5]`)
   In most cases that will not happen.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org