You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/11 13:03:41 UTC

[GitHub] [commons-bcel] garydgregory commented on a change in pull request #58: BCEL-341: Oak class file patch

garydgregory commented on a change in pull request #58:
URL: https://github.com/apache/commons-bcel/pull/58#discussion_r468562200



##########
File path: src/main/java/org/apache/bcel/classfile/ClassParser.java
##########
@@ -303,5 +304,6 @@ private void readMethods() throws IOException, ClassFormatException {
     private void readVersion() throws IOException, ClassFormatException {
         minor = dataInputStream.readUnsignedShort();
         major = dataInputStream.readUnsignedShort();
+        isOak = major < Const.MAJOR_1_1 || (major == Const.MAJOR_1_1 && minor < 3);

Review comment:
       Should the check be `minor <= 3` instead? See notes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org