You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2023/06/28 03:57:35 UTC
[GitHub] [arrow] laurentgo opened a new pull request, #36341: GH-36340: [Java] Address race condition in allocator logger thread
laurentgo opened a new pull request, #36341:
URL: https://github.com/apache/arrow/pull/36341
### Rationale for this change
Address a race condition where the allocator logger thread starts logging before the class is fully initialized
### What changes are included in this PR?
Change initialization order within the allocator to address the race condition.
Add list of log messages captured during the test run if the assertion failed.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
Closes apache/arrow#36340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36341: GH-36340: [Java] Address race condition in allocator logger thread
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36341:
URL: https://github.com/apache/arrow/pull/36341#issuecomment-1616144667
Conbench analyzed the 6 benchmark runs on commit `264b072e`.
There were 3 benchmark results indicating a performance regression:
- Commit Run on `arm64-t4g-linux-compute` at [2023-06-28 14:05:16Z](http://conbench.ursa.dev/compare/runs/c5f8856d12084fe09cdc754a1b987198...c52ee103f2ed4b7c86805bb933036b1a/)
- [params=num_cols:64/is_partial:0/real_time, source=cpp-micro, suite=arrow-ipc-read-write-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649c3242c45749f8000443e4dca3bc0...0649c3e7493c7dcd80008e8abdb57b6e)
- Commit Run on `ursa-thinkcentre-m75q` at [2023-06-30 04:12:44Z](http://conbench.ursa.dev/compare/runs/3fdea120f11e4710a2b87695067f0188...a4248842c8c140dba3d39e368fe31b15/)
- [params=1048576/10000, source=cpp-micro, suite=arrow-acero-aggregate-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649e2e9357178ad8000d1b39d62560d...0649e56758ad723c80002fa73ee6426a)
- and 1 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14711561685) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #36341: GH-36340: [Java] Address race condition in allocator logger thread
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #36341:
URL: https://github.com/apache/arrow/pull/36341#issuecomment-1611293112
CC @davisusanibar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36341: GH-36340: [Java] Address race condition in allocator logger thread
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36341:
URL: https://github.com/apache/arrow/pull/36341#issuecomment-1610651982
:warning: GitHub issue #36340 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #36341: GH-36340: [Java] Address race condition in allocator logger thread
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #36341:
URL: https://github.com/apache/arrow/pull/36341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org