You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2018/11/15 09:59:31 UTC
[incubator-dubbo] branch dev-metadata updated (dc23a34 -> 453e323)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a change to branch dev-metadata
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git.
from dc23a34 Add pom dependency
new a3f9a54 change log level to info
new 453e323 ignore parameter(exclude=true).
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/java/org/apache/dubbo/config/AbstractConfig.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[incubator-dubbo] 02/02: ignore parameter(exclude=true).
Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch dev-metadata
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
commit 453e323b4b955505b9c3ef10340f55ab8a3ca4a0
Author: ken.lj <ke...@gmail.com>
AuthorDate: Thu Nov 15 17:58:54 2018 +0800
ignore parameter(exclude=true).
---
.../src/main/java/org/apache/dubbo/config/AbstractConfig.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
index 130aa03..0be4c41 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
@@ -459,7 +459,9 @@ public abstract class AbstractConfig implements Serializable {
} else {
key = prop;
}
- if (method.getReturnType() == Object.class || parameter != null && parameter.excluded()) {
+ // treat url and configuration differently, the value should always present in configuration though it may not need to present in url.
+ //if (method.getReturnType() == Object.class || parameter != null && parameter.excluded()) {
+ if (method.getReturnType() == Object.class) {
metaData.put(key, null);
continue;
}
[incubator-dubbo] 01/02: change log level to info
Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch dev-metadata
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
commit a3f9a541c5752d449b38f360b1bcb6ae0876cd37
Author: ken.lj <ke...@gmail.com>
AuthorDate: Thu Nov 15 17:35:50 2018 +0800
change log level to info
---
.../src/main/java/org/apache/dubbo/config/AbstractConfig.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
index a883973..130aa03 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
@@ -544,7 +544,7 @@ public abstract class AbstractConfig implements Serializable {
method.invoke(this, convertPrimitive(method.getParameterTypes()[0], value));
}
} catch (NoSuchMethodException e) {
- logger.warn("Failed to override the property " + method.getName() + " in " + this.getClass().getSimpleName() + ", please make sure every property has a getter/setter pair.", e);
+ logger.info("Failed to override the property " + method.getName() + " in " + this.getClass().getSimpleName() + ", please make sure every property has a getter/setter pair.");
}
}
}