You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (Created) (JIRA)" <ji...@apache.org> on 2012/01/27 17:18:10 UTC
[jira] [Created] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
CheckFileSystem does not correctly honor setVerifyChecksum
----------------------------------------------------------
Key: HADOOP-7998
URL: https://issues.apache.org/jira/browse/HADOOP-7998
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.23.0, 0.24.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195239#comment-13195239 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #451 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/451/])
merge HADOOP-7998
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197007#comment-13197007 ]
Todd Lipcon commented on HADOOP-7998:
-------------------------------------
This commit seems to have broken HDFS's TestFSInputChecker. See https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/testReport/junit/org.apache.hadoop.hdfs/TestFSInputChecker/testFSInputChecker/
Daryn, can you take a look?
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195174#comment-13195174 ]
Robert Joseph Evans commented on HADOOP-7998:
---------------------------------------------
Your patch looks good +1. I looked at the javadoc warnings and they are
{noformat}
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21: warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:49: warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50: warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
[WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
{noformat}
All of them look like acceptable usage, and the first 6 kerberos ones are already ignored so I will bump the javadoc warning number as part of the commit.
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7998:
--------------------------------
Attachment: HADOOP-7998.patch
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195199#comment-13195199 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1605 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1605/])
HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
Files :
* /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195192#comment-13195192 ]
Robert Joseph Evans commented on HADOOP-7998:
---------------------------------------------
I just committed this to trunk and 0.23. Thanks for your work on this.
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-7998:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.1
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Status: Resolved (was: Patch Available)
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195202#comment-13195202 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #426 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/426/])
merge HADOOP-7998
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195524#comment-13195524 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #152 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/152/])
merge HADOOP-7998
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195209#comment-13195209 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1621 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1621/])
HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
Files :
* /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7998:
--------------------------------
Attachment: HADOOP-7998-2.patch
tests are more comprehensive
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195545#comment-13195545 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #972 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/972/])
HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
Files :
* /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197015#comment-13197015 ]
Uma Maheswara Rao G commented on HADOOP-7998:
---------------------------------------------
Yes Todd, I already filed HADOOP-8006. We both working on it. thanks
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195147#comment-13195147 ]
Hadoop QA commented on HADOOP-7998:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512235/HADOOP-7998-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 7 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//console
This message is automatically generated.
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195055#comment-13195055 ]
Robert Joseph Evans commented on HADOOP-7998:
---------------------------------------------
I like the patch. It seems fairly straight forward, but the test you added in seems a bit too whitebox for my taste. The test requires that the checksum validation be done the way it is currently done. That may be an OK assumption, but I would rather see the test not need to make that assumption, and instead validate that reading a file with an invalid checksum file will work with verify checksum disabled.
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195196#comment-13195196 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1677 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1677/])
HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
Files :
* /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195502#comment-13195502 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #939 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/])
HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
Files :
* /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195515#comment-13195515 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #174 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/174/])
merge HADOOP-7998
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7998:
--------------------------------
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Status: Patch Available (was: Open)
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7998) CheckFileSystem does not correctly
honor setVerifyChecksum
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195198#comment-13195198 ]
Hudson commented on HADOOP-7998:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #435 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/435/])
merge HADOOP-7998
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
> Key: HADOOP-7998
> URL: https://issues.apache.org/jira/browse/HADOOP-7998
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.1
>
> Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira