You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by duraza <gi...@git.apache.org> on 2017/04/01 03:42:49 UTC

[GitHub] beam pull request #2397: [BEAM-1684] Add unit tests for iobase.py.

GitHub user duraza opened a pull request:

    https://github.com/apache/beam/pull/2397

    [BEAM-1684] Add unit tests for iobase.py.

    **Summary**: This pull request adds unit tests for Dataflow's `iobase.py`
    **Comments**: As this is my first PR to Beam, I erred on the side of caution, adding a large number of tests. The file I am testing is largely a base class with limited functionality, so these tests are very likely to be redundant, and debatably unnecessary. Please let me know, and I'll be sure to correct accordingly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duraza/beam add-dataflow-iobase-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2397
    
----
commit 96f77cd61cb6f9b001e5f53d15c9ef2418111b48
Author: Rahul Sabbineni <du...@users.noreply.github.com>
Date:   2017-04-01T03:35:21Z

    [BEAM-1684] Add unit tests for iobase.py.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2397: [BEAM-1684] Add unit tests for iobase.py.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2397


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---