You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2022/01/27 12:21:08 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

PierreSmits opened a new pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494


   The issue exists also in the older version.
   The field "requirementByDate" form "FindApprovedProductRequirements" in RequirementForms.xml has been set wrongly and it should be "requiredByDate".
   This causes the result could not be queried out properly as indicated as below:
   The result is governed by the service "getRequirementsForSupplier", where reads the list from the view "RequirementAndRole".
   In the view entity definition, the field is defined as
   <alias entity-alias="RQ" name="requiredByDate"/>, but it is not the case in the form "FindApprovedProductRequirements" above.
   
   Modified: RequirementForms.xml
   - changed field requirementByDate into requiredByDate as per entity definition for Requirement
   
   Thanks to Schumann Ye for reporting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux closed pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494#issuecomment-1025640443


   Fixed directly in OFBIZ-12505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494#issuecomment-1023345883


   Thanks Michael,
   
   Will do. I guess you meant perform a **git pull asf trunk --rebase**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494#issuecomment-1023151542


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=494&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=494) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=494&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=494&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl commented on pull request #494: Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)

Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #494:
URL: https://github.com/apache/ofbiz-framework/pull/494#issuecomment-1023331465


   Please, Pierre, use git pull --rebase to merge trunk in your feature branches to avoid those nasty empty merge commits. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org