You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2009/09/11 05:36:57 UTC
[jira] Created: (MAPREDUCE-973) Move "FailJob" from examples to
test
Move "FailJob" from examples to test
------------------------------------
Key: MAPREDUCE-973
URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: examples, test
Affects Versions: 0.21.0
Reporter: Chris Douglas
Fix For: 0.21.0
The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753978#action_12753978 ]
Owen O'Malley commented on MAPREDUCE-973:
-----------------------------------------
Go ahead and just move sleep job too. I can't see any one minding. The examples are certainly public evolving, anyways.
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated MAPREDUCE-973:
------------------------------------
Resolution: Fixed
Assignee: Chris Douglas
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Chris!
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754831#action_12754831 ]
Philip Zeyliger commented on MAPREDUCE-973:
-------------------------------------------
Thanks!
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754442#action_12754442 ]
Hudson commented on MAPREDUCE-973:
----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #31 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/31/])
. Move FailJob and SleepJob from examples to test. (cdouglas
via omalley)
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753976#action_12753976 ]
Philip Zeyliger commented on MAPREDUCE-973:
-------------------------------------------
If you haven't done this already, I'm happy to move it to test. Should SleepJob move too?
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Fix For: 0.21.0
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Attachment: M973-0.patch
bq. If you haven't done this already, I'm happy to move it to test. Should SleepJob move too?
SleepJob was added in 2007 so we'd have to deprecate, etc. to do that. Since FailJob was added in 0.21, it's easy to move.
Attached a trivial move to src/test
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Fix For: 0.21.0
>
> Attachments: M973-0.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Status: Patch Available (was: Open)
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Status: Open (was: Patch Available)
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754031#action_12754031 ]
Hadoop QA commented on MAPREDUCE-973:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419261/M973-0.patch
against trunk revision 813660.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/61/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/61/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/61/console
This message is automatically generated.
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Status: Patch Available (was: Open)
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Description: The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests. (was: The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.)
Summary: Move test utilities from examples to test (was: Move "FailJob" from examples to test)
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Priority: Trivial (was: Major)
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-973) Move test utilities from examples
to test
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754164#action_12754164 ]
Hadoop QA commented on MAPREDUCE-973:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419269/M973-1.patch
against trunk revision 813660.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 34 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/64/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/64/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/64/console
This message is automatically generated.
> Move test utilities from examples to test
> -----------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed. Similarly, SleepJob class is mostly used in unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-973) Move "FailJob" from examples to
test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-973:
------------------------------------
Attachment: M973-1.patch
Soright. Moved SleepJob to src/test
> Move "FailJob" from examples to test
> ------------------------------------
>
> Key: MAPREDUCE-973
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-973
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: examples, test
> Affects Versions: 0.21.0
> Reporter: Chris Douglas
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: M973-0.patch, M973-1.patch
>
>
> The FailJob class (MAPREDUCE-567) is more a test utility than an example. It should either move to src/test, ideally with a unit test built around it, or be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.