You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/19 09:50:53 UTC

[GitHub] [solr] risdenk commented on a diff in pull request #1087: SOLR-16442: simplify 'license update' step in lucene-upgrade.md

risdenk commented on code in PR #1087:
URL: https://github.com/apache/solr/pull/1087#discussion_r999209274


##########
dev-docs/lucene-upgrade.md:
##########
@@ -43,11 +43,7 @@ gradlew --write-locks
 ### `solr/licenses` update
 
 ```
-git rm lucene-*-9.3.0.jar.sha1
-
-# ???manually get new .sha1 files???
-
-git add lucene-*-9.4.0.jar.sha1
+gradlew updateLicenses
 ```
 
 ## Code

Review Comment:
   Personally I use `./gradlew check -x test` for any changes without tests instead of just compile. I bet it's slower, but it runs all the spotless and other checks. 
   
   Then when I'm happy it builds, I remove the `-x test` to run tests.
   
   Not sure this makes it better in this case :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org