You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by kw...@apache.org on 2023/03/10 11:31:34 UTC
[jackrabbit-filevault] branch master updated: JCRVLT-693 Escape values of type UNDEFINED as well (#280)
This is an automated email from the ASF dual-hosted git repository.
kwin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jackrabbit-filevault.git
The following commit(s) were added to refs/heads/master by this push:
new c23e4049 JCRVLT-693 Escape values of type UNDEFINED as well (#280)
c23e4049 is described below
commit c23e4049be3dcf0ab9c4d911a6ad1b1306ae3ae6
Author: Konrad Windszus <kw...@apache.org>
AuthorDate: Fri Mar 10 12:31:28 2023 +0100
JCRVLT-693 Escape values of type UNDEFINED as well (#280)
---
.../java/org/apache/jackrabbit/vault/util/DocViewProperty2.java | 1 +
.../org/apache/jackrabbit/vault/util/DocViewProperty2Test.java | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty2.java b/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty2.java
index d17a84f5..98ab931e 100644
--- a/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty2.java
+++ b/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty2.java
@@ -442,6 +442,7 @@ public class DocViewProperty2 {
case PropertyType.STRING:
case PropertyType.NAME:
case PropertyType.PATH:
+ case PropertyType.UNDEFINED:
attrValue.append(escape(value, isMultiValue));
break;
default:
diff --git a/vault-core/src/test/java/org/apache/jackrabbit/vault/util/DocViewProperty2Test.java b/vault-core/src/test/java/org/apache/jackrabbit/vault/util/DocViewProperty2Test.java
index 51edc3e9..cc710ee0 100644
--- a/vault-core/src/test/java/org/apache/jackrabbit/vault/util/DocViewProperty2Test.java
+++ b/vault-core/src/test/java/org/apache/jackrabbit/vault/util/DocViewProperty2Test.java
@@ -39,6 +39,7 @@ import org.apache.jackrabbit.spi.Name;
import org.apache.jackrabbit.spi.commons.conversion.DefaultNamePathResolver;
import org.apache.jackrabbit.spi.commons.conversion.IllegalNameException;
import org.apache.jackrabbit.spi.commons.conversion.NameResolver;
+import org.apache.jackrabbit.spi.commons.name.NameConstants;
import org.apache.jackrabbit.spi.commons.name.NameFactoryImpl;
import org.apache.jackrabbit.spi.commons.namespace.NamespaceMapping;
import org.apache.jackrabbit.value.ValueFactoryImpl;
@@ -201,6 +202,13 @@ public class DocViewProperty2Test {
Assert.assertEquals(new DocViewProperty2(nameFoo, Arrays.asList(""), PropertyType.UNDEFINED), dp);
}
+ @Test
+ public void testUndefinedType() {
+ DocViewProperty2 dp = new DocViewProperty2(NameConstants.JCR_LASTMODIFIEDBY, "[Bar\"\\");
+ String actualValue = dp.formatValue();
+ Assert.assertEquals("\\[Bar\"\\\\", actualValue);
+ }
+
@Test
public void testEmptyMVBoolean() throws Exception {
Property p = Mockito.mock(Property.class);