You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dylanwong250 (via GitHub)" <gi...@apache.org> on 2025/09/02 22:19:16 UTC
[PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
dylanwong250 opened a new pull request, #52202:
URL: https://github.com/apache/spark/pull/52202
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "dylanwong250 (via GitHub)" <gi...@apache.org>.
dylanwong250 commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2330687223
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -1280,3 +1298,35 @@ object SymmetricHashJoinStateManager {
}
}
}
+
+/**
+ * Options controlling snapshot-based state replay.
+ */
+case class SnapshotOptions(
+ snapshotVersion: Long,
+ endVersion: Long,
+ startKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ startKeyWithIndexToValueStateStoreCkptId: Option[String] = None,
+ endKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ endKeyWithIndexToValueStateStoreCkptId: Option[String] = None) {
+ def getKeyToNumValuesHandlerOpts(): HandlerSnapshotOptions =
+ HandlerSnapshotOptions(
+ snapshotVersion = snapshotVersion,
+ endVersion = endVersion,
+ startStateStoreCkptId = startKeyToNumValuesStateStoreCkptId,
+ endStateStoreCkptId = endKeyToNumValuesStateStoreCkptId)
+
+ def getKeyWithIndexToValueHandlerOpts(): HandlerSnapshotOptions =
+ HandlerSnapshotOptions(
+ snapshotVersion = snapshotVersion,
+ endVersion = endVersion,
+ startStateStoreCkptId = startKeyWithIndexToValueStateStoreCkptId,
+ endStateStoreCkptId = endKeyWithIndexToValueStateStoreCkptId)
+ }
+
+/** Snapshot options specialized for a single state store handler. */
+case class HandlerSnapshotOptions(
Review Comment:
Made private[join]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "dylanwong250 (via GitHub)" <gi...@apache.org>.
dylanwong250 commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2323436252
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -1032,7 +1031,7 @@ case class RocksDBCheckpointMetadata(
/** Helper class for [[RocksDBCheckpointMetadata]] */
object RocksDBCheckpointMetadata {
- val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion
+ val VERSION = 1
Review Comment:
I want to point out this change. I believe using `val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion` is incorrect in this case and I was seeing a few test failures. The `QLConf.get.stateStoreCheckpointFormatVersion` refers to the checkpoint format version not the metadata format version. Additionally, since this is inside an object as a val it will be instantiated once and is not the current value of SQLConf.get.stateStoreCheckpointFormatVersion. I think this VERSION may be shared incorrectly also.
I also experimented with having VERSION equal to the current value. I ran into a few issues with the maintenance threads having a different version than the streaming query they were ran in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "dylanwong250 (via GitHub)" <gi...@apache.org>.
dylanwong250 commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2323436252
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -1032,7 +1031,7 @@ case class RocksDBCheckpointMetadata(
/** Helper class for [[RocksDBCheckpointMetadata]] */
object RocksDBCheckpointMetadata {
- val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion
+ val VERSION = 1
Review Comment:
I want to point out this change. I believe using `val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion` is incorrect in this case and I was seeing a few test failures. The `VERSION` refers to the checkpoint format version not the metadata format. Additionally, since this is inside an object as a val it will be instantiated once and is not the current value of SQLConf.get.stateStoreCheckpointFormatVersion. I think this VERSION may be shared incorrectly also.
I also experimented with having VERSION equal to the current value. I ran into a few issues with the maintenance threads having a different version than the streaming query they were ran in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "dylanwong250 (via GitHub)" <gi...@apache.org>.
dylanwong250 commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2330685228
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -509,13 +515,19 @@ abstract class SymmetricHashJoinStateManager(
storeProviderId, keySchema, valueSchema, NoPrefixKeyStateEncoderSpec(keySchema),
useColumnFamilies = useVirtualColumnFamilies, storeConf, hadoopConf,
useMultipleValuesPerKey = false, stateSchemaProvider = None)
- if (snapshotStartVersion.isDefined) {
+ if (handlerSnapshotOptions.isDefined) {
if (!stateStoreProvider.isInstanceOf[SupportsFineGrainedReplay]) {
throw StateStoreErrors.stateStoreProviderDoesNotSupportFineGrainedReplay(
stateStoreProvider.getClass.toString)
}
+ val opts = handlerSnapshotOptions.get
stateStoreProvider.asInstanceOf[SupportsFineGrainedReplay]
- .replayStateFromSnapshot(snapshotStartVersion.get, stateInfo.get.storeVersion)
+ .replayStateFromSnapshot(
+ opts.snapshotVersion,
+ opts.endVersion,
+ readOnly = false,
Review Comment:
I initially had it to readOnly = false to match what the replayStateFromSnapshot default value was without the uniqueIds. Also looking at the previous PR for snapshot reading https://github.com/apache/spark/pull/46944 it seems the readOnly option did not exist at the time. I changed to readOnly = true and all the tests pass so I think it is better to switch to readOnly = true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "liviazhu (via GitHub)" <gi...@apache.org>.
liviazhu commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2331412193
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -1280,3 +1300,35 @@ object SymmetricHashJoinStateManager {
}
}
}
+
+/**
+ * Options controlling snapshot-based state replay for state data source reader.
+ */
+case class SnapshotOptions(
+ snapshotVersion: Long,
+ endVersion: Long,
+ startKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ startKeyWithIndexToValueStateStoreCkptId: Option[String] = None,
+ endKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ endKeyWithIndexToValueStateStoreCkptId: Option[String] = None) {
+ def getKeyToNumValuesHandlerOpts(): HandlerSnapshotOptions =
Review Comment:
nit: indents seem wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2335132153
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -707,8 +724,11 @@ abstract class SymmetricHashJoinStateManager(
* A wrapper around a [[StateStore]] that stores the mapping; the mapping depends on the
* state format version - please refer implementations of [[KeyWithIndexToValueRowConverter]].
*/
- protected class KeyWithIndexToValueStore(stateFormatVersion: Int)
- extends StateStoreHandler(KeyWithIndexToValueType, keyWithIndexToValueStateStoreCkptId) {
+ protected class KeyWithIndexToValueStore(
+ stateFormatVersion: Int,
Review Comment:
nit: this should be 4 spaces here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "micheal-o (via GitHub)" <gi...@apache.org>.
micheal-o commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2326477513
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -509,13 +515,19 @@ abstract class SymmetricHashJoinStateManager(
storeProviderId, keySchema, valueSchema, NoPrefixKeyStateEncoderSpec(keySchema),
useColumnFamilies = useVirtualColumnFamilies, storeConf, hadoopConf,
useMultipleValuesPerKey = false, stateSchemaProvider = None)
- if (snapshotStartVersion.isDefined) {
+ if (handlerSnapshotOptions.isDefined) {
if (!stateStoreProvider.isInstanceOf[SupportsFineGrainedReplay]) {
throw StateStoreErrors.stateStoreProviderDoesNotSupportFineGrainedReplay(
stateStoreProvider.getClass.toString)
}
+ val opts = handlerSnapshotOptions.get
stateStoreProvider.asInstanceOf[SupportsFineGrainedReplay]
- .replayStateFromSnapshot(snapshotStartVersion.get, stateInfo.get.storeVersion)
+ .replayStateFromSnapshot(
+ opts.snapshotVersion,
+ opts.endVersion,
+ readOnly = false,
Review Comment:
why is `readOnly` false for state reader?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -1280,3 +1298,35 @@ object SymmetricHashJoinStateManager {
}
}
}
+
+/**
+ * Options controlling snapshot-based state replay.
Review Comment:
nit: include "for state data source reader"
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -681,9 +681,14 @@ class RocksDB(
* Note that the instance will be read-only since this method is only used in State Data
* Source.
*/
- def loadFromSnapshot(snapshotVersion: Long, endVersion: Long): RocksDB = {
+ def loadFromSnapshot(
+ snapshotVersion: Long,
+ endVersion: Long,
+ snapshotVersionStateStoreCkptId: Option[String] = None,
+ endVersionStateStoreCkptId: Option[String] = None): RocksDB = {
Review Comment:
nit: update func param comment
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -1280,3 +1298,35 @@ object SymmetricHashJoinStateManager {
}
}
}
+
+/**
+ * Options controlling snapshot-based state replay.
+ */
+case class SnapshotOptions(
+ snapshotVersion: Long,
+ endVersion: Long,
+ startKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ startKeyWithIndexToValueStateStoreCkptId: Option[String] = None,
+ endKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ endKeyWithIndexToValueStateStoreCkptId: Option[String] = None) {
+ def getKeyToNumValuesHandlerOpts(): HandlerSnapshotOptions =
+ HandlerSnapshotOptions(
+ snapshotVersion = snapshotVersion,
+ endVersion = endVersion,
+ startStateStoreCkptId = startKeyToNumValuesStateStoreCkptId,
+ endStateStoreCkptId = endKeyToNumValuesStateStoreCkptId)
+
+ def getKeyWithIndexToValueHandlerOpts(): HandlerSnapshotOptions =
+ HandlerSnapshotOptions(
+ snapshotVersion = snapshotVersion,
+ endVersion = endVersion,
+ startStateStoreCkptId = startKeyWithIndexToValueStateStoreCkptId,
+ endStateStoreCkptId = endKeyWithIndexToValueStateStoreCkptId)
+ }
+
+/** Snapshot options specialized for a single state store handler. */
+case class HandlerSnapshotOptions(
Review Comment:
nit: private?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -801,7 +801,11 @@ trait SupportsFineGrainedReplay {
* @param endVersion checkpoint version to end with
*/
def replayStateFromSnapshot(
- snapshotVersion: Long, endVersion: Long, readOnly: Boolean = false): StateStore
+ snapshotVersion: Long,
+ endVersion: Long,
+ readOnly: Boolean = false,
+ snapshotVersionStateStoreCkptId: Option[String] = None,
Review Comment:
ditto
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -721,10 +730,16 @@ class RocksDB(
* @param snapshotVersion start checkpoint version
* @param endVersion end version
*/
- private def replayFromCheckpoint(snapshotVersion: Long, endVersion: Long): Any = {
+ private def replayFromCheckpoint(
+ snapshotVersion: Long,
+ endVersion: Long,
+ snapshotVersionStateStoreCkptId: Option[String] = None,
+ endVersionStateStoreCkptId: Option[String] = None): Any = {
Review Comment:
ditto
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -813,8 +817,18 @@ trait SupportsFineGrainedReplay {
* @param snapshotVersion checkpoint version of the snapshot to start with
* @param endVersion checkpoint version to end with
*/
- def replayReadStateFromSnapshot(snapshotVersion: Long, endVersion: Long): ReadStateStore = {
- new WrappedReadStateStore(replayStateFromSnapshot(snapshotVersion, endVersion, readOnly = true))
+ def replayReadStateFromSnapshot(
+ snapshotVersion: Long,
+ endVersion: Long,
+ snapshotVersionStateStoreCkptId: Option[String] = None,
+ endVersionStateStoreCkptId: Option[String] = None): ReadStateStore = {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "dylanwong250 (via GitHub)" <gi...@apache.org>.
dylanwong250 commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2331439876
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -1280,3 +1300,35 @@ object SymmetricHashJoinStateManager {
}
}
}
+
+/**
+ * Options controlling snapshot-based state replay for state data source reader.
+ */
+case class SnapshotOptions(
+ snapshotVersion: Long,
+ endVersion: Long,
+ startKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ startKeyWithIndexToValueStateStoreCkptId: Option[String] = None,
+ endKeyToNumValuesStateStoreCkptId: Option[String] = None,
+ endKeyWithIndexToValueStateStoreCkptId: Option[String] = None) {
+ def getKeyToNumValuesHandlerOpts(): HandlerSnapshotOptions =
Review Comment:
Fixed. I used https://github.com/databricks/scala-style-guide?tab=readme-ov-file#spacing-and-indentation for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "liviazhu (via GitHub)" <gi...@apache.org>.
liviazhu commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2331111509
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -1032,7 +1031,7 @@ case class RocksDBCheckpointMetadata(
/** Helper class for [[RocksDBCheckpointMetadata]] */
object RocksDBCheckpointMetadata {
- val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion
+ val VERSION = 1
Review Comment:
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #52202:
URL: https://github.com/apache/spark/pull/52202#discussion_r2335131583
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StreamStreamJoinStatePartitionReader.scala:
##########
@@ -82,18 +82,36 @@ class StreamStreamJoinStatePartitionReader(
partition.sourceOptions.startOperatorStateUniqueIds,
usesVirtualColumnFamilies)
- private val keyToNumValuesStateStoreCkptId = if (joinSide == LeftSide) {
+ private val endStateStoreCheckpointIds =
+ SymmetricHashJoinStateManager.getStateStoreCheckpointIds(
+ partition.partition,
Review Comment:
nit: indent for the args ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option) [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db closed pull request #52202: [SPARK-53332][SS] Enable StateDataSource with state checkpoint v2 (only snapshotStartBatchId option)
URL: https://github.com/apache/spark/pull/52202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org