You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/05/17 04:32:31 UTC
[GitHub] codecov-io commented on issue #3668: Fixes asymmetry between
reading and writing of ByteSize.
codecov-io commented on issue #3668: Fixes asymmetry between reading and writing of ByteSize.
URL: https://github.com/apache/incubator-openwhisk/pull/3668#issuecomment-389741389
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=h1) Report
> Merging [#3668](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/ed71ee0cb0dd72eaf1166d0380e2ce2a75f5a9e0?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/graphs/tree.svg?token=l0YmsiSAso&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3668 +/- ##
==========================================
+ Coverage 74.49% 74.49% +<.01%
==========================================
Files 126 126
Lines 5990 5994 +4
Branches 390 392 +2
==========================================
+ Hits 4462 4465 +3
- Misses 1528 1529 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `97.82% <100%> (+0.2%)` | :arrow_up: |
| [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=footer). Last update [ed71ee0...041b2c6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3668?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services