[GitHub] [flink] snuyanzin commented on a diff in pull request #22127: [FLINK-31351][sql-gateway] Don't stop the stuck thread by force

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #22127:
URL: https://github.com/apache/flink/pull/22127#discussion_r1129192778


##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/operation/OperationManagerTest.java:
##########
@@ -64,8 +66,8 @@ public class OperationManagerTest {
             new ExecutorThreadFactory(
                     "SqlGatewayService Test Pool", IgnoreExceptionHandler.INSTANCE);
 
-    @BeforeAll
-    public static void setUp() {
+    @BeforeEach
+    public void setUp() {

Review Comment:
   nit: modifier could be package private
   ```suggestion
       void setUp() {
   ```



##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/operation/OperationManagerTest.java:
##########
@@ -129,29 +135,54 @@ public void testCancelOperation() throws Exception {
     }
 
     @Test
-    public void testCancelOperationByForce() throws Exception {
-        AtomicReference<Throwable> exception = new AtomicReference<>(null);
+    public void testCancelUninterruptedOperation() throws Exception {

Review Comment:
   nit: modifier could be package private
   ```suggestion
       void testCancelUninterruptedOperation() throws Exception {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org