You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "shishkovilja (via GitHub)" <gi...@apache.org> on 2026/08/01 14:29:58 UTC
[PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
shishkovilja opened a new pull request, #13424:
URL: https://github.com/apache/ignite/pull/13424
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5151982557
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13424:
URL: https://github.com/apache/ignite/pull/13424#discussion_r3713368980
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -132,14 +132,26 @@ public static void restoreDefaultSerializeVersion() {
* @return Allow all service permissions.
*/
public static Map<String, Collection<SecurityPermission>> compatibleServicePermissions() {
- Map<String, Collection<SecurityPermission>> srvcPerms = new HashMap<>();
+ Map<String, EnumSet<SecurityPermission>> srvcPerms = new HashMap<>();
- srvcPerms.put("*", Arrays.asList(
+ srvcPerms.put("*", EnumSet.of(
SecurityPermission.SERVICE_CANCEL,
SecurityPermission.SERVICE_DEPLOY,
SecurityPermission.SERVICE_INVOKE));
- return srvcPerms;
+ return upcast(srvcPerms);
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
+ public static Map<String, Collection<SecurityPermission>> upcast(Map<String, EnumSet<SecurityPermission>> map) {
+ return (Map<String, Collection<SecurityPermission>>)(Map)map;
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
Review Comment:
@petrov-mg , IDE tells me, that it is "redundand" suppression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5167516442
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5190063859
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #13424:
URL: https://github.com/apache/ignite/pull/13424#discussion_r3706051472
##########
modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java:
##########
@@ -201,10 +208,47 @@ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundE
else
srvcPermissions = Collections.emptyMap();
}
+
+ convert();
}
/** {@inheritDoc} */
@Override public String toString() {
return S.toString(SecurityBasicPermissionSet.class, this);
}
+
+ /** {@inheritDoc} */
+ @Override public void marshal(Marshaller marsh) throws IgniteCheckedException {
+ // No-op.
+ }
+
+ /** {@inheritDoc} */
+ @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr) throws IgniteCheckedException {
+ // Message framework uses ArrayList for ordinary collectons, so we need convert it explicitly.
+ convert();
+ }
+
+ /** */
+ private void convert() {
Review Comment:
convert -> normalize?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -132,14 +132,26 @@ public static void restoreDefaultSerializeVersion() {
* @return Allow all service permissions.
*/
public static Map<String, Collection<SecurityPermission>> compatibleServicePermissions() {
- Map<String, Collection<SecurityPermission>> srvcPerms = new HashMap<>();
+ Map<String, EnumSet<SecurityPermission>> srvcPerms = new HashMap<>();
- srvcPerms.put("*", Arrays.asList(
+ srvcPerms.put("*", EnumSet.of(
SecurityPermission.SERVICE_CANCEL,
SecurityPermission.SERVICE_DEPLOY,
SecurityPermission.SERVICE_INVOKE));
- return srvcPerms;
+ return upcast(srvcPerms);
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
Review Comment:
```suggestion
@SuppressWarnings({"rawtypes", "unchecked"})
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -132,14 +132,26 @@ public static void restoreDefaultSerializeVersion() {
* @return Allow all service permissions.
*/
public static Map<String, Collection<SecurityPermission>> compatibleServicePermissions() {
- Map<String, Collection<SecurityPermission>> srvcPerms = new HashMap<>();
+ Map<String, EnumSet<SecurityPermission>> srvcPerms = new HashMap<>();
- srvcPerms.put("*", Arrays.asList(
+ srvcPerms.put("*", EnumSet.of(
SecurityPermission.SERVICE_CANCEL,
SecurityPermission.SERVICE_DEPLOY,
SecurityPermission.SERVICE_INVOKE));
- return srvcPerms;
+ return upcast(srvcPerms);
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
+ public static Map<String, Collection<SecurityPermission>> upcast(Map<String, EnumSet<SecurityPermission>> map) {
+ return (Map<String, Collection<SecurityPermission>>)(Map)map;
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
Review Comment:
```suggestion
@SuppressWarnings({"rawtypes", "unchecked"})
```
##########
modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java:
##########
@@ -201,10 +208,47 @@ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundE
else
srvcPermissions = Collections.emptyMap();
}
+
+ convert();
}
/** {@inheritDoc} */
@Override public String toString() {
return S.toString(SecurityBasicPermissionSet.class, this);
}
+
+ /** {@inheritDoc} */
+ @Override public void marshal(Marshaller marsh) throws IgniteCheckedException {
+ // No-op.
+ }
+
+ /** {@inheritDoc} */
+ @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr) throws IgniteCheckedException {
+ // Message framework uses ArrayList for ordinary collectons, so we need convert it explicitly.
Review Comment:
Typo.
##########
modules/core/src/test/java/org/apache/ignite/plugin/security/SecurityPermissionSetBuilderTest.java:
##########
@@ -143,8 +142,8 @@ public void testPermissionBuilder() {
* @param perms Permissions.
* @return Collection.
*/
- static Collection<SecurityPermission> permissions(SecurityPermission... perms) {
- Collection<SecurityPermission> col = U.newHashSet(perms.length);
+ static EnumSet<SecurityPermission> permissions(SecurityPermission... perms) {
Review Comment:
It seems that we can drop this method and use `EnumSet.of(<permisisons>)` instead.
##########
modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java:
##########
@@ -201,10 +208,47 @@ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundE
else
srvcPermissions = Collections.emptyMap();
}
+
+ convert();
}
/** {@inheritDoc} */
@Override public String toString() {
return S.toString(SecurityBasicPermissionSet.class, this);
}
+
+ /** {@inheritDoc} */
+ @Override public void marshal(Marshaller marsh) throws IgniteCheckedException {
+ // No-op.
+ }
+
+ /** {@inheritDoc} */
+ @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr) throws IgniteCheckedException {
+ // Message framework uses ArrayList for ordinary collectons, so we need convert it explicitly.
+ convert();
+ }
+
+ /** */
+ private void convert() {
+ cachePermissions = toEnumSetMap(cachePermissions);
+ taskPermissions = toEnumSetMap(taskPermissions);
+ srvcPermissions = toEnumSetMap(srvcPermissions);
+ sysPermissions = copySafe(sysPermissions);
+ }
+
+ /**
+ * @param cachePermissions Cache permissions.
+ * @return Map with enum sets of security permissions.
+ */
+ public static Map<String, Collection<SecurityPermission>> toEnumSetMap(
Review Comment:
toEnumSetMap -> normalizeValueType?
##########
modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java:
##########
@@ -201,10 +208,47 @@ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundE
else
srvcPermissions = Collections.emptyMap();
}
+
+ convert();
}
/** {@inheritDoc} */
@Override public String toString() {
return S.toString(SecurityBasicPermissionSet.class, this);
}
+
+ /** {@inheritDoc} */
+ @Override public void marshal(Marshaller marsh) throws IgniteCheckedException {
+ // No-op.
+ }
+
+ /** {@inheritDoc} */
+ @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr) throws IgniteCheckedException {
+ // Message framework uses ArrayList for ordinary collectons, so we need convert it explicitly.
+ convert();
+ }
+
+ /** */
+ private void convert() {
+ cachePermissions = toEnumSetMap(cachePermissions);
+ taskPermissions = toEnumSetMap(taskPermissions);
+ srvcPermissions = toEnumSetMap(srvcPermissions);
+ sysPermissions = copySafe(sysPermissions);
+ }
+
+ /**
+ * @param cachePermissions Cache permissions.
+ * @return Map with enum sets of security permissions.
+ */
+ public static Map<String, Collection<SecurityPermission>> toEnumSetMap(
+ Map<String, Collection<SecurityPermission>> cachePermissions
+ ) {
+ return cachePermissions.entrySet().stream()
+ .collect(Collectors.toMap(Map.Entry::getKey, e -> copySafe(e.getValue())));
+ }
+
+ /** */
+ private static EnumSet<SecurityPermission> copySafe(Collection<SecurityPermission> col) {
+ return col != null ? EnumSet.copyOf(col) : EnumSet.noneOf(SecurityPermission.class);
Review Comment:
We can check if `col` is `instanceof EnumSet<SecurityPermission>`
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -366,7 +378,8 @@ public static void authorizeAll(IgniteSecurity security, SecurityPermissionSet p
}
/** */
- private static void authorizeAll(IgniteSecurity security, Map<String, Collection<SecurityPermission>> permissions) {
+ private static void authorizeAll(IgniteSecurity security,
Review Comment:
No line break is needed here.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -132,14 +132,26 @@ public static void restoreDefaultSerializeVersion() {
* @return Allow all service permissions.
*/
public static Map<String, Collection<SecurityPermission>> compatibleServicePermissions() {
- Map<String, Collection<SecurityPermission>> srvcPerms = new HashMap<>();
+ Map<String, EnumSet<SecurityPermission>> srvcPerms = new HashMap<>();
- srvcPerms.put("*", Arrays.asList(
+ srvcPerms.put("*", EnumSet.of(
SecurityPermission.SERVICE_CANCEL,
SecurityPermission.SERVICE_DEPLOY,
SecurityPermission.SERVICE_INVOKE));
- return srvcPerms;
+ return upcast(srvcPerms);
+ }
+
+ /** @param map Map. */
Review Comment:
We need something more meaningful here, or we should simply leave it empty.
The same below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5205439623
<!-- tcbot-analysis-comment chainBuildId=9259254 rerunBuildIds=none -->
### TCBot Test Analysis
* TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9259254&buildTypeId=IgniteTests24Java8_RunAll)
* Branch: `pull/13424/head`
* Base: `master`
* Tested commit: [b9dabdf](https://github.com/apache/ignite/pull/13424/commits/b9dabdf42c9c2cb79e9d3ca98a2ffb692f39fa61)
#### Possible Blockers (1)
* [\[Check Code Style Ducktests\]](https://ci2.ignite.apache.org/viewLog.html?buildId=9259463): 0 tests Exit Code
* Exit Code is a blocker. Base branch fail rate is 3,3%
#### New Tests (1)
* [Security](https://ci2.ignite.apache.org/viewLog.html?buildId=9259188): 1 tests
* `SecurityTestSuite`: `SecurityBasicPermissionSetSerializationTest.testWithNullAndEmptyPermissions` - PASSED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5151857427
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13424:
URL: https://github.com/apache/ignite/pull/13424#discussion_r3713363311
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityUtils.java:
##########
@@ -132,14 +132,26 @@ public static void restoreDefaultSerializeVersion() {
* @return Allow all service permissions.
*/
public static Map<String, Collection<SecurityPermission>> compatibleServicePermissions() {
- Map<String, Collection<SecurityPermission>> srvcPerms = new HashMap<>();
+ Map<String, EnumSet<SecurityPermission>> srvcPerms = new HashMap<>();
- srvcPerms.put("*", Arrays.asList(
+ srvcPerms.put("*", EnumSet.of(
SecurityPermission.SERVICE_CANCEL,
SecurityPermission.SERVICE_DEPLOY,
SecurityPermission.SERVICE_INVOKE));
- return srvcPerms;
+ return upcast(srvcPerms);
+ }
+
+ /** @param map Map. */
+ @SuppressWarnings("rawtypes")
Review Comment:
@petrov-mg , IDE tells me, that it is "redundand" suppression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5190773442
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5194233940
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5159366278
<!-- tcbot-analysis-comment chainBuildId=9246529 rerunBuildIds=9248201,9248203,9248205 -->
### TCBot Test Analysis
* TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9246529&buildTypeId=IgniteTests24Java8_RunAll)
* Branch: `pull/13424/head`
* Base: `master`
* Tested commit: [6668733](https://github.com/apache/ignite/pull/13424/commits/66687339eac8abf34f0dd3622c032c80b4493433)
#### Possible Blockers (0)
No blockers found.
#### New Tests (0)
No new tests found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5152020922
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5181619768
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5169390278
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5194604254
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13424:
URL: https://github.com/apache/ignite/pull/13424#issuecomment-5201138479
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28944 Refactor SecurityBasicPermissionSet [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja merged PR #13424:
URL: https://github.com/apache/ignite/pull/13424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org