You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "jgehrcke (via GitHub)" <gi...@apache.org> on 2023/08/10 13:20:27 UTC

[GitHub] [arrow] jgehrcke opened a new issue, #37106: `arrow-compute-scalar-round-benchmark` fails with `Rounding to -5 digits is out of range for type int16`

jgehrcke opened a new issue, #37106:
URL: https://github.com/apache/arrow/issues/37106

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   In benchmarking pipelines we [see](https://github.com/voltrondata-labs/arrow-benchmarks-ci/issues/160) that `arrow-compute-scalar-round-benchmark` fails with code 6, emitting `Invalid: Rounding to -5 digits is out of range for type int16` on stderr. The first commit that produces this error was https://github.com/apache/arrow/commit/7c8f398f32ba5d2685093a010002f729a01a4242. It seems to be strongly related :).
   
   
   
   
   
   ### Component(s)
   
   Archery, Benchmarking


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou closed issue #37106: [C++] `arrow-compute-scalar-round-benchmark` fails with `Rounding to -5 digits is out of range for type int16`

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #37106: [C++] `arrow-compute-scalar-round-benchmark` fails with `Rounding to -5 digits is out of range for type int16`
URL: https://github.com/apache/arrow/issues/37106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] js8544 commented on issue #37106: [C++] `arrow-compute-scalar-round-benchmark` fails with `Rounding to -5 digits is out of range for type int16`

Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on issue #37106:
URL: https://github.com/apache/arrow/issues/37106#issuecomment-1673299546

   > @js8544 Could you perhaps take a look?
   The easiest fix I can think of is to remove the benchmark for uint8, int8, uint16 and int16 types. I think the 32 and 64 bits are good enough to represent integers since they are the most commonly used types. Does it sound good to you? @pitrou 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on issue #37106: [C++] `arrow-compute-scalar-round-benchmark` fails with `Rounding to -5 digits is out of range for type int16`

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #37106:
URL: https://github.com/apache/arrow/issues/37106#issuecomment-1673236689

   @js8544 Could you perhaps take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org