You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2025/09/11 04:30:45 UTC
[PR] ui: allow assigning backup offring during instance deploy [cloudstack]
shwstppr opened a new pull request, #11612:
URL: https://github.com/apache/cloudstack/pull/11612
### Description
Add backup offering selection to Deploy VM wizard and assign selected backup offering to the VM after successful deployment. This enables users to choose a backup offering during VM creation, and the VM is automatically associated with the selected offering post-deployment.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3301519855
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3301856709
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290620094
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-751)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow assigning backup offring during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3277645441
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-747)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3285296149
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3285293074
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290864992
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-752)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3291520204
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-753)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow assigning backup offring during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3277467207
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3285358272
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-748)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#discussion_r2347907270
##########
ui/public/locales/pt_BR.json:
##########
@@ -292,7 +292,8 @@
"label.availability": "Disponibilidade",
"label.available": "Dispon\u00edvel",
"label.back": "Voltar",
-"label.backup": "Backups",
+"label.backup": "Backup",
+"label.backups": "Backup",
Review Comment:
```suggestion
"label.backup": "Backup",
"label.backups": "Backups",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290583718
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290810633
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290809250
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3291447312
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3291451661
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3288134374
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3288133643
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#discussion_r2347911167
##########
ui/src/views/compute/wizard/DeployInstanceBackupSelection.vue:
##########
@@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <div>{{ $t('message.backup.provision.instance') }}</div>
+ <infinite-scroll-select
+ style="margin-top: 10px; width: 100%;"
+ v-model:value="localBackupOfferingId"
+ placeholder="Select backup offering"
+ api="listBackupOfferings"
+ :apiParams="listBackupOfferingApiParams"
+ resourceType="backupoffering"
+ defaultIcon="cloud-upload-outlined"
+ :defaultOption="backupOfferingDefaultOption"
+ @change-option="handleChangeBackupOffering" />
+
+ <div v-if="backupOfferingId && 'createBackupSchedule' in $store.getters.apis" style="margin-top: 15px">
+ <a-form-item :label="$t('label.schedule')">
+ <a-button
+ type="dashed"
+ style="width: 100%"
+ @click="onShowAddBackupSchedule">
+ <template #icon><plus-outlined /></template>
+ {{ $t('label.add.backup.schedule') }}
+ </a-button>
+ </a-form-item>
+ <backup-schedule
+ style="margin-top: 10px;"
+ :dataSource="backupSchedules"
+ :deleteFn="handleDeleteBackupSchedule" />
+ </div>
+
+ <a-modal
+ style="min-width: 400px;"
+ :visible="showAddBackupSchedule"
+ :title="$t('label.add.backup.schedule')"
+ :maskClosable="false"
+ :closable="true"
+ :footer="null"
+ @cancel="closeModals">
+ <form-schedule
+ :resource="addFormResource"
+ :submitFn="handleAddBackupSchedule" />
+ </a-modal>
+ </div>
+</template>
+
+<script>
+import InfiniteScrollSelect from '@/components/widgets/InfiniteScrollSelect'
+import BackupSchedule from '@views/compute/backup/BackupSchedule'
+import FormSchedule from '@views/compute/backup/FormSchedule'
+
+export default {
+ name: 'DeployInstanceBackupSelection',
+ components: {
+ InfiniteScrollSelect,
+ BackupSchedule,
+ FormSchedule
+ },
+ props: {
+ zoneId: {
+ type: String,
+ default: null
+ },
+ backupOfferingId: {
+ type: String,
+ default: null
+ },
+ backupSchedules: {
+ type: Array,
+ default: () => []
+ }
+ },
+ data () {
+ return {
+ backupOffering: null,
+ showAddBackupSchedule: false,
+ localBackupOfferingId: this.backupOfferingId
+ }
+ },
+ provide () {
+ return {
+ refreshSchedule: null,
+ closeSchedule: this.closeModals
+ }
+ },
+ emits: ['change-backup-offering', 'add-backup-schedule', 'delete-backup-schedule', 'update:backupOfferingId'],
+ computed: {
+ listBackupOfferingApiParams () {
+ return {
+ zoneid: this.zoneId
+ }
+ },
+ backupOfferingDefaultOption () {
+ return { id: null, name: this.$t('label.noselect'), showicon: false }
+ },
+ addFormResource () {
+ return {
+ id: 'NEW',
+ backupofferingid: this.backupOfferingId,
+ backupoffering: this.backupOffering
+ }
+ }
+ },
+ watch: {
+ localBackupOfferingId (val) {
+ if (val !== this.backupOfferingId) {
+ this.$emit('update:backupOfferingId', val)
+ }
+ },
+ backupOfferingId (val) {
+ if (val !== this.localBackupOfferingId) {
+ this.localBackupOfferingId = val
+ }
+ }
+ },
+ methods: {
+ handleChangeBackupOffering (offering) {
+ this.$emit('change-backup-offering', offering)
+ this.backupOffering = offering
+ },
+ onShowAddBackupSchedule () {
+ this.showAddBackupSchedule = true
+ },
+ handleAddBackupSchedule (schedule) {
+ schedule.id = 'SCH_' + new Date().getTime()
+ schedule.intervaltype = schedule.intervaltype?.toUpperCase()
+ this.$emit('add-backup-schedule', schedule)
+ console.log('Added schedule', schedule)
Review Comment:
Console.log statements should not be included in production code. Remove this debug statement.
```suggestion
```
##########
ui/src/views/compute/DeployVM.vue:
##########
@@ -3395,6 +3431,97 @@ export default {
return
}
this.form.externaldetails = undefined
+ },
+ onChangeBackupOffering (val) {
+ if (!val || !val.id) {
+ this.selectedBackupOffering = null
+ this.backupSchedules = []
+ return
+ }
+ this.selectedBackupOffering = val
+ if (this.backupSchedules && this.backupSchedules.length > 0 && !['nas'].includes(val.provider)) {
Review Comment:
The hardcoded provider check `['nas'].includes(val.provider)` is a magic value that should be documented or extracted to a constant to explain why 'nas' provider is treated differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3290582632
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3288160180
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11612 (QA-JID-749)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow provisioning backups during instance deploy [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3301512630
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow assigning backup offring during instance deploy [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3277442955
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11612?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.63%. Comparing base ([`3d6ec29`](https://app.codecov.io/gh/apache/cloudstack/commit/3d6ec29c9bb87dafe01ad39e2a1dda9d4e644d6c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`666a362`](https://app.codecov.io/gh/apache/cloudstack/commit/666a3626e29119b77ef7ef58a84634c37a9dcd86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 18 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (3d6ec29) and HEAD (666a362). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (3d6ec29) | HEAD (666a362) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11612 +/- ##
=============================================
- Coverage 17.36% 3.63% -13.74%
=============================================
Files 5888 441 -5447
Lines 525741 37045 -488696
Branches 64164 6791 -57373
=============================================
- Hits 91274 1345 -89929
+ Misses 424167 35538 -388629
+ Partials 10300 162 -10138
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11612/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.63% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11612?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: allow assigning backup offring during instance deploy [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11612:
URL: https://github.com/apache/cloudstack/pull/11612#issuecomment-3277475852
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org