You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2018/05/12 13:10:59 UTC

[03/34] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/32dd633b
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/32dd633b
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/32dd633b

Branch: refs/heads/HBASE-19064
Commit: 32dd633b9899a2cae70c017c33a616701d6cf7bc
Parents: 9c046c0
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:08:35 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/32dd633b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index dc13645..bcb23ac 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -272,9 +272,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       try {
         POOL.latchCountUp();
         if (runCleaner()) {
-          LOG.debug("Cleaned all WALs under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("Cleaned all WALs under {}", oldFileDir);
+          }
         } else {
-          LOG.warn("WALs outstanding under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("WALs outstanding under {}", oldFileDir);
+          }
         }
       } finally {
         POOL.latchCountDown();
@@ -287,7 +291,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
         POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }