You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/26 08:46:51 UTC

[GitHub] [airflow] potiuk commented on pull request #29772: Support deleting the local log files when using remote logging

potiuk commented on PR #29772:
URL: https://github.com/apache/airflow/pull/29772#issuecomment-1445300546

   > We should mention it in the docs (probably in remote logging part) otherwise users won't be aware they can set this
   
   Yes. I agree right now it is not at all obvious how to do it (you really need to copy local settings and add new keyword parameters and somehow know that they are there (many of our users are kinda scared to look at the source code to find out how thing really are and expect documentation to tell them what they can do 🤷 ),
   
   I would say it would be worth to actually add an option `as well` to airflow configuration (and update default local settins to read the configuration) - it will still allow to use the feature without upgrading airflow. But in the future it will be as easy as modifying the configuration.
   
   Also you will be able to copy the local_settings from latest airflow version, add configuration (even if you do not upgrade) and new providers and - surprisingly - it will also work, because you do not have to have new airflow ot read new value from the config. I think for the future - compatibility, this could be even described in the docs how to approach it - copy the relevant part of settings, add configuration, and then when you migrate in the future, it will **just work** (TM).
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org