You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2019/04/04 22:59:00 UTC

[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github

    [ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810366#comment-16810366 ] 

Kenneth Knowles commented on BEAM-6595:
---------------------------------------

Working on this, I want to note that it is OK to publish to various places, as that is required. The places that it does, and make sense, are:

 - SVN staging for the source, java, and python artifacts
 - PR for the javadocs and pydocs (only pushes to the user's github)
 - pushing the RC tag to apache/beam seems acceptable as part of this

> build_release_candidate.sh should not push to apache org on github
> ------------------------------------------------------------------
>
>                 Key: BEAM-6595
>                 URL: https://issues.apache.org/jira/browse/BEAM-6595
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>              Labels: triaged
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, the build_release_candidate.sh does many things beyond the build
>  - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT
>  - Makes a local commit
>  - Pushes commits to release branch
>  - Reverts on failure, pushes those to release branch
> Instead, the release manager should determine what gets pushed. It is less fragile of a process and avoids cruft getting pushed and churning the branch. The only thing the plugin is really good for is flipping SNAPSHOT away and back. And it isn't even that great because that's Java only and other languages are at non-SNAPSHOT anyhow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)