You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/02 02:27:54 UTC
[GitHub] [inlong] haifxu opened a new pull request, #5320: [INLONG-4929][Manager] Add stream source api in manager client
haifxu opened a new pull request, #5320:
URL: https://github.com/apache/inlong/pull/5320
### [INLONG-4929][Manager] Add stream source api in manager client
- Fixes #4929
### Motivation
Supplement the API that the manager web exists but the client does not exist for manager client.
### Modifications
Add get stream source by id api in manager client.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is already covered by existing tests, such as:
org.apache.inlong.manager.client.api.inner.ClientFactoryTest#testGetStreamSourceById
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5320: [INLONG-4929][Manager] Add stream source API in Manager client
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5320:
URL: https://github.com/apache/inlong/pull/5320#discussion_r935062105
##########
inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/ClientFactoryTest.java:
##########
@@ -907,4 +910,32 @@ void testGetNode() {
ClusterNodeResponse clientNode = clusterClient.getNode(1);
Assertions.assertEquals(1, clientNode.getId());
}
+
+ @Test
+ void testGetStreamSourceById() {
+ StreamSource streamSource = MySQLBinlogSource.builder()
+ .id(1)
+ .inlongGroupId("test_group")
+ .inlongStreamId("test_stream")
+ .sourceType(SourceType.MYSQL_BINLOG)
+ .sourceName("test_source")
+ .agentIp("127.0.0.1")
+ .inlongClusterName("test_cluster")
+ .user("root")
Review Comment:
Please use `.user("root").password("pwd")` instead of `root`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #5320: [INLONG-4929][Manager] Add stream source API in Manager client
Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #5320:
URL: https://github.com/apache/inlong/pull/5320#discussion_r935066834
##########
inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/ClientFactoryTest.java:
##########
@@ -907,4 +910,32 @@ void testGetNode() {
ClusterNodeResponse clientNode = clusterClient.getNode(1);
Assertions.assertEquals(1, clientNode.getId());
}
+
+ @Test
+ void testGetStreamSourceById() {
+ StreamSource streamSource = MySQLBinlogSource.builder()
+ .id(1)
+ .inlongGroupId("test_group")
+ .inlongStreamId("test_stream")
+ .sourceType(SourceType.MYSQL_BINLOG)
+ .sourceName("test_source")
+ .agentIp("127.0.0.1")
+ .inlongClusterName("test_cluster")
+ .user("root")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5320: [INLONG-4929][Manager] Add stream source API in Manager client
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5320:
URL: https://github.com/apache/inlong/pull/5320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org